Skip to content

aws: dynamodb_cdc send to close channel bug fix#4168

Merged
squiidz merged 1 commit intomainfrom
bugfix_dynamodb_cdc_send_to_closed_channel
Mar 25, 2026
Merged

aws: dynamodb_cdc send to close channel bug fix#4168
squiidz merged 1 commit intomainfrom
bugfix_dynamodb_cdc_send_to_closed_channel

Conversation

@squiidz
Copy link
Contributor

@squiidz squiidz commented Mar 25, 2026

No description provided.

@claude
Copy link

claude bot commented Mar 25, 2026

Commits

  1. aws: dynamodb_cdc send to close channel bug fix — message should use imperative mood per commit policy. e.g., aws: fix send to closed channel in dynamodb_cdc

Review
Clean fix for a send-on-closed-channel race in the DynamoDB CDC shard coordinator. The new sync.WaitGroup correctly ensures all shard reader goroutines finish before msgChan is closed.

LGTM

Copy link
Contributor

@mmatczuk mmatczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modernize, otherwise LGTM

@squiidz squiidz force-pushed the bugfix_dynamodb_cdc_send_to_closed_channel branch from 2b490c2 to 9dc6dc3 Compare March 25, 2026 16:13
@claude
Copy link

claude bot commented Mar 25, 2026

Commits

  1. aws: dynamodb_cdc send to close channel bug fix — message does not use imperative mood. Should be something like aws: fix send-on-closed-channel in dynamodb_cdc. See commit policy: messages must use imperative mood (e.g., "fix", not "bug fix").

Review
The fix correctly ensures shard reader goroutines complete before closing d.msgChan, preventing a send-on-closed-channel panic. Uses sync.WaitGroup.Go to track goroutine lifecycle and defers cleanup in the right order: cancel → wait → close.

LGTM

@squiidz squiidz merged commit fa029c1 into main Mar 25, 2026
8 checks passed
@squiidz squiidz deleted the bugfix_dynamodb_cdc_send_to_closed_channel branch March 25, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants