Skip to content

oracledb_cdc: add source_ts_ms metadata#4250

Merged
josephwoodward merged 2 commits intomainfrom
jw/oraclecdctimestamp
Apr 13, 2026
Merged

oracledb_cdc: add source_ts_ms metadata#4250
josephwoodward merged 2 commits intomainfrom
jw/oraclecdctimestamp

Conversation

@josephwoodward
Copy link
Copy Markdown
Contributor

@josephwoodward josephwoodward commented Apr 13, 2026

This change adds the source_ts_ms field to a message's metadata which represents the timestamp of when Oracle wrote the change record into the redo log.

It also removes redundant json encoding tags as they're irrelevant.

image

None of these fields are encoded to json so tags can be removed to make
it clearer.
@josephwoodward josephwoodward force-pushed the jw/oraclecdctimestamp branch from b146d7c to ab7d945 Compare April 13, 2026 16:26
@claude
Copy link
Copy Markdown

claude bot commented Apr 13, 2026

Commits

  1. Commit ab7d945 (oracledb_cdc: propagate the source timestamp to consumers) mixes code and documentation changes. The .adoc file update at docs/modules/components/pages/inputs/oracledb_cdc.adoc should be in a separate commit from the code changes, per the commit policy: "In multi-commit PRs, documentation changes must be in a separate commit from code changes."

Review
Adds source_ts_ms metadata to oracledb_cdc messages with the redo log timestamp in millis since epoch. Implementation is clean: guarded by a zero-time check, consistent with existing metadata patterns, and covered by integration test assertions.

LGTM

@josephwoodward josephwoodward merged commit 36090c3 into main Apr 13, 2026
7 checks passed
@josephwoodward josephwoodward deleted the jw/oraclecdctimestamp branch April 13, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants