Skip to content

amqp1: fix data race in randomString#4260

Merged
mmatczuk merged 1 commit intomainfrom
mmt/amqp1-fix-data-race
Apr 15, 2026
Merged

amqp1: fix data race in randomString#4260
mmatczuk merged 1 commit intomainfrom
mmt/amqp1-fix-data-race

Conversation

@mmatczuk
Copy link
Copy Markdown
Contributor

@mmatczuk mmatczuk commented Apr 15, 2026

Replace package-level *rand.Rand (not goroutine-safe) with top-level rand.Intn which is safe for concurrent use since Go 1.20+

Fixes CON-398

Replace package-level *rand.Rand (not goroutine-safe) with top-level
rand.Intn which is safe for concurrent use since Go 1.20+.

Fixes CON-398
@claude
Copy link
Copy Markdown

claude bot commented Apr 15, 2026

Commits
LGTM

Review
Clean fix replacing a non-goroutine-safe package-level *rand.Rand with the thread-safe top-level rand.Intn (safe since Go 1.20+). Minimal, correct, and well-scoped.

LGTM

@mmatczuk mmatczuk merged commit 931f782 into main Apr 15, 2026
7 checks passed
@mmatczuk mmatczuk deleted the mmt/amqp1-fix-data-race branch April 15, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants