frontend: move to tanstack router #2132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malinskibeniamin
force-pushed
the
tanstack-router
branch
2 times, most recently
from
547c509 to
b406a4c
Compare
malinskibeniamin
changed the title
malinskibeniamin
force-pushed
the
tanstack-router
branch
from
b406a4c to
1cd8810
Compare
malinskibeniamin
requested review from
a team,
Mateoc,
c-julin,
jvorcak and
yougotashovel
and removed request for
a team
malinskibeniamin
force-pushed
the
tanstack-router
branch
from
b2c3809 to
191f08c
Compare
Changes Made:
1. SidebarLogo
- Added aria-label="Go to Overview" to the link
- Set alt="" on decorative image (aria-label describes the action)
2. SidebarCollapseToggle
- Added aria-expanded to indicate sidebar state
- Added aria-label describing the action
- Added aria-hidden="true" to icons
3. UserProfileNew
- Added aria-label to dropdown trigger (User menu for {name})
- Added aria-hidden="true" to all decorative icons (ChevronUp, Settings, LogOut)
- Set alt="" on avatar image (aria-label on button describes context)
4. SidebarNavItem
- Added aria-current="page" for active navigation items
- Added aria-disabled for disabled items
- Added aria-hidden="true" to nav icons
- Changed disabled item container from <div> to <span role="link"> for better semantics
5. SidebarNavigation
- Wrapped menu in <nav aria-label="Main navigation"> landmark
malinskibeniamin
force-pushed
the
tanstack-router
branch
from
f2b394c to
ee0e036
Compare
malinskibeniamin
force-pushed
the
tanstack-router
branch
from
ee0e036 to
4b1e632
Compare
malinskibeniamin
force-pushed
the
tanstack-router
branch
from
180e5bd to
4a21470
Compare
malinskibeniamin
force-pushed
the
tanstack-router
branch
from
0987b28 to
c11b892
Compare
jvorcak
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates Redpanda Console frontend from React Router to TanStack Router with file-based routing, and removes all React Router DOM dependencies.
Key Changes
src/routes/matching URL structure (e.g.,topics/$topicName/index.tsx)@tanstack/react-router,@tanstack/router-plugin, and@tanstack/zod-adapterreact-router-dom- no longer needed after full migrationroute-utils.tsxproviding sidebar item generation, visibility management, and embedded mode support withgroupandisBetafieldssidebar-new.tsx), deleted legacy files (sidebar-legacy.tsx,user-button.tsx,sidebar-item-badge.tsx,sidebar-utils.tsx)@redpanda-data/uiBreadcrumbs (React Router dependent) with redpanda-ui registry Breadcrumb components using TanStack RouterLinkrouter-sync.tsxfor MobX store integration with router stateMigration Approach
Recording
