frontend: fix shadow links page crash when feature is disabled#2225
Merged
frontend: fix shadow links page crash when feature is disabled#2225
Conversation
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Shadow Links should remain visible in the sidebar even when the feature is disabled so users can see instructions on how to enable it. The loader try-catch handles FailedPrecondition gracefully for disabled clusters.
… clusters Non-Redpanda clusters (e.g. Apache Kafka) return Code.Unavailable because the Redpanda Admin API doesn't exist. Previously this showed the same FeatureDisabled card with an `rpk` command, which is incorrect for these clusters. Add a separate ShadowLinkUnavailableState with an info alert explaining that shadowing requires a Redpanda cluster with the Admin API.
c-julin
force-pushed
the
jc/fix-shadowlink-tab
branch
from
3df3a58 to
e187687
Compare
weeco
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FailedPreconditionwhen cluster linking is disabled, causing TanStack Router to show a generic error pageShadowLinkListPagecomponent already handles this error gracefully (shows "enable shadowing" card), but never renders because the loader throws firstensureQueryDatain a try/catch that swallowsFailedPrecondition, letting the component handle it