ci: add proto generate check workflow#2322
Merged
Conversation
c-julin
force-pushed
the
ci/proto-generate-check
branch
from
13f9fe9 to
c592464
Compare
c-julin
force-pushed
the
ci/proto-generate-check
branch
from
c592464 to
396254f
Compare
weeco
reviewed
Mar 18, 2026
Comment on lines
+43
to
+46
| - name: Generate protos | ||
| env: | ||
| BUF_TOKEN: ${{ secrets.BUF_TOKEN }} | ||
| run: task proto:generate No newline at end of file |
Contributor
There was a problem hiding this comment.
Where's the check? I guess we don't want the CI to generate the protos, we just want it to check if there's a diff after generating the protos right?
Also we need to pin the common-go dependency to avoid the random protogens due to other work e.g. policy materializer here) I assume
Contributor
Author
There was a problem hiding this comment.
the check was already in the taskfile and yes we do, theres a different issue with the policy materializer as it the first service in common-go that breaks our generate 😭
The policymaterializer service in buf.build/redpandadata/common doesn't generate grpc server types in common-go, causing connect-gateway to produce unresolvable imports. Console doesn't use this service, so exclude it from generation.
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / validate (pull_request).
|
weeco
approved these changes
Mar 18, 2026
Pin buf.build/redpandadata/common to a specific commit and update buf.build/gen/go/redpandadata/core to resolve missing admin/v2 types. Also exclude policymaterializer from frontend generation.
Change -f (file test) to -d (directory test) for build/bin/go which is a directory, not a file. This allows Task to correctly detect cached tool binaries and skip reinstallation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task proto:generateon PRs touching proto filesgit diff --exit-codecheck in the task)