refactor: consume common and ai-gateway protos from BSR packages#2324
Merged
refactor: consume common and ai-gateway protos from BSR packages#2324
Conversation
Remove buf.build/redpandadata/common and buf.build/redpandadata/ai-gateway as explicit inputs from buf.gen.backend.yaml and buf.gen.frontend.yaml. Backend: common types are consumed as pre-built Go packages from the BSR SDK (buf.build/gen/go/redpandadata/common/protocolbuffers/go), matching the pattern used by cloudv2. This eliminates the policymaterializer codegen issue entirely. Frontend: common and ai-gateway types are consumed from BSR npm packages (@buf/redpandadata_common.bufbuild_es, @buf/redpandadata_ai-gateway.bufbuild_es, @buf/redpandadata_ai-gateway.connectrpc_query-es). Only console's own dataplane protos are generated locally.
- Add check-bsr-versions task to proto:generate that verifies Go and npm BSR SDK package versions match the commits pinned in buf.lock - Remove unused buf.build/redpandadata/ai-gateway dep from buf.yaml - Pin Go BSR common dep to match buf.lock commit
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / validate (pull_request).
|
21cdee3 to
ce6ff7a
Compare
weeco
reviewed
Mar 18, 2026
buf.yaml
Outdated
| - buf.build/grpc-ecosystem/grpc-gateway:v2.24.0 | ||
| - buf.build/redpandadata/common:5d899910f71449dda17179c2e198100d | ||
| - buf.build/redpandadata/core:05aa34b3829a4d5a801d9487623a7c76 | ||
| - buf.build/redpandadata/core |
Contributor
There was a problem hiding this comment.
Removing the version here - is this intended?
Contributor
Author
There was a problem hiding this comment.
oh good catch it wasn't it was only meant to be temporary
weeco
approved these changes
Mar 18, 2026
Unpin buf.build/redpandadata/core to latest (923579c57f1c) which includes admin/v2 types needed by monitoring and shadowlink gateway code. Also commits all regenerated .gw.go files that were missing.
ce6ff7a to
d203bb7
Compare
weeco
added a commit
that referenced
this pull request
Mar 19, 2026
Remove buf.build/redpandadata/common and buf.build/redpandadata/ai-gateway module inputs from buf.gen.frontend.yaml. These types are now consumed from pre-built BSR npm packages per PR #2324, not generated locally.
weeco
added a commit
that referenced
this pull request
Mar 19, 2026
* proto: add transcript service and regenerate protobuf/openapi definitions Adds the transcript proto definition for the dataplane v1alpha3 API and regenerates all protobuf (backend Go, frontend TS) and OpenAPI outputs. * chore(proto): pin ai-gateway version in buf.gen.frontend.yaml and regenerate Pin ai-gateway to commit 0d2811b8 to prevent unrelated proto changes from leaking into PRs that only need to regenerate dataplane protos. * fix: revert buf.gen.frontend.yaml to match master's BSR package approach Remove buf.build/redpandadata/common and buf.build/redpandadata/ai-gateway module inputs from buf.gen.frontend.yaml. These types are now consumed from pre-built BSR npm packages per PR #2324, not generated locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buf.build/redpandadata/commonandbuf.build/redpandadata/ai-gatewayas explicit inputs frombuf.gen.backend.yamlandbuf.gen.frontend.yaml@buf/redpandadata_common.bufbuild_es,@buf/redpandadata_ai-gateway.bufbuild_es,@buf/redpandadata_ai-gateway.connectrpc_query-es)