fix(proto): exclude AgentRegistryService from cloud proto generation#2409
Conversation
AgentRegistryService (redpanda/api/adp/v1alpha1/agent.proto) is a server-side registry API that the console UI never calls. PR #2401 unintentionally manifested it when scoping the cloud BSR module input to redpanda/api/adp. Add exclude_paths to drop agent.proto so the generated client stays out of this public-facing repo. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@claude review |
|
Claude finished @malinskibeniamin's task in 1m 8s —— View job PR Review
Overall: LGTM — clean and minimal change. The PR correctly excludes
|
Run task proto:generate to sync checked-in output with current upstream sources. Picks up 2026 copyright bump in google/api/resource_pb.ts and openapi formatting drift from the v1/v1alpha2 generators. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
exclude_paths: [redpanda/api/adp/v1alpha1/agent.proto]to thebuf.build/redpandadata/cloudinput inbuf.gen.frontend.yamlagent_pb.tsandagent-AgentRegistryService_connectquery.ts— nothing in the frontend consumesAgentRegistryServiceWhy
Reviewer concern on #2401: the adp path scoping pulled in
agent.proto(AgentRegistryService, a server-side registry API) even though the console UI never calls it. Explicitly excluding it keeps the generated client out of this repo.Test plan
task proto:generate(or equivalent) produces noagent*files underadp/v1alpha1/bun run type:checkpassesfrontend/src(outsideprotogen/) importsAgentRegistryService🤖 Generated with Claude Code