Skip to content

fix(proto): exclude AgentRegistryService from cloud proto generation#2409

Merged
malinskibeniamin merged 2 commits intomasterfrom
bm/exclude-agent-registry-from-proto-gen
Apr 22, 2026
Merged

fix(proto): exclude AgentRegistryService from cloud proto generation#2409
malinskibeniamin merged 2 commits intomasterfrom
bm/exclude-agent-registry-from-proto-gen

Conversation

@malinskibeniamin
Copy link
Copy Markdown
Contributor

@malinskibeniamin malinskibeniamin commented Apr 22, 2026

Summary

  • Add exclude_paths: [redpanda/api/adp/v1alpha1/agent.proto] to the buf.build/redpandadata/cloud input in buf.gen.frontend.yaml
  • Remove generated agent_pb.ts and agent-AgentRegistryService_connectquery.ts — nothing in the frontend consumes AgentRegistryService
  • Follow-up to fix(proto): scope cloud BSR module to adp protos only #2401, addressing reviewer feedback that the agent registry service shouldn't be manifested in this repo

Why

Reviewer concern on #2401: the adp path scoping pulled in agent.proto (AgentRegistryService, a server-side registry API) even though the console UI never calls it. Explicitly excluding it keeps the generated client out of this repo.

Test plan

  • task proto:generate (or equivalent) produces no agent* files under adp/v1alpha1/
  • All other adp services (llm_provider, mcp_server, model, oauth_connection, oauth_provider, token_vault_admin) still generate
  • bun run type:check passes
  • No source under frontend/src (outside protogen/) imports AgentRegistryService

🤖 Generated with Claude Code

AgentRegistryService (redpanda/api/adp/v1alpha1/agent.proto) is a
server-side registry API that the console UI never calls. PR #2401
unintentionally manifested it when scoping the cloud BSR module input
to redpanda/api/adp. Add exclude_paths to drop agent.proto so the
generated client stays out of this public-facing repo.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@malinskibeniamin
Copy link
Copy Markdown
Contributor Author

@claude review

@malinskibeniamin malinskibeniamin enabled auto-merge (squash) April 22, 2026 11:09
@claude
Copy link
Copy Markdown

claude Bot commented Apr 22, 2026

Claude finished @malinskibeniamin's task in 1m 8s —— View job


PR Review

  • Read CLAUDE.md for repo guidelines
  • Review buf.gen.frontend.yaml changes
  • Verify no frontend source imports the deleted files
  • Check deleted generated files for correctness
  • Provide final review feedback

Overall: LGTM — clean and minimal change. The PR correctly excludes agent.proto from cloud proto generation and safely removes the two generated files.

buf.gen.frontend.yaml

The change is syntactically correct for buf v2. exclude_paths is properly nested under the buf.build/redpandadata/cloud module input (not at top-level), which is the right placement to scope the exclusion to that input only:

- module: buf.build/redpandadata/cloud:4d513424c2de4ca4b584eba3f1dce48d
  paths:
    - redpanda/api/adp
  exclude_paths:
    - redpanda/api/adp/v1alpha1/agent.proto   # ← correct placement

No issues here.

Deleted generated files

I verified that no source file outside frontend/src/protogen/ imports AgentRegistryService, agent_pb, or agent-AgentRegistry. The removal is safe.

The remaining 6 adp services in protogen/redpanda/api/adp/v1alpha1/ (llm_provider, mcp_server, model, oauth_connection, oauth_provider, token_vault_admin) are untouched, confirming the exclude_paths is scoped correctly and doesn't affect them.

Minor observations (non-blocking)

  1. Pinned module digest — the cloud module is pinned to 4d513424c2de4ca4b584eba3f1dce48d. This is fine and expected for reproducible generation; just noting it's worth keeping in sync with any future proto bumps in the same way PR fix(proto): scope cloud BSR module to adp protos only #2401 did.

  2. No source-level consumers — since nothing under frontend/src (outside protogen/) ever imported these files, the deletion has zero runtime risk. Good to confirm this was the intent and it checks out.

Summary

The change is correct, well-scoped, and achieves exactly what the PR description says. The test plan items are verifiable and the approach is sound. Approving.

Run task proto:generate to sync checked-in output with current upstream
sources. Picks up 2026 copyright bump in google/api/resource_pb.ts and
openapi formatting drift from the v1/v1alpha2 generators.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@malinskibeniamin malinskibeniamin requested a review from a team April 22, 2026 14:40
@malinskibeniamin malinskibeniamin merged commit a252246 into master Apr 22, 2026
19 checks passed
@malinskibeniamin malinskibeniamin deleted the bm/exclude-agent-registry-from-proto-gen branch April 22, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants