Conversation
The topic config editor showed an "Infinite" button for every config whose frontendFormat was BYTE_SIZE or DURATION. For configs that the broker hard-caps (e.g. max.message.bytes, segment.bytes), clicking it submitted -1, which the broker reinterpreted as 4294967295 and rejected with INVALID_CONFIG. Add an opt-out field `noInfiniteValue` to the config extension schema. Configs that do not accept an infinite sentinel declare it in JSON, and the frontend hides the Infinite button for them. BYTE_SIZE and DURATION configs continue to show the button by default. Apply the opt-out to max.message.bytes and segment.bytes.
c-julin
changed the title
c-julin
changed the title
c-julin
requested review from
jvorcak and
malinskibeniamin
and removed request for
malinskibeniamin
chakra-react-select's container has an intrinsic maxWidth: fit-content, so even with a minW on the wrapping Box the SingleSelect collapses to the width of its current value. For message.timestamp.type with no initial value the whole control rendered at ~69px and option labels were truncated to "Creat" / "LogA". Override via chakraStyles on the SELECT case to set container minWidth: 240px directly. Keeps the Custom Box layout untouched for BYTE_SIZE / DURATION controls.
c-julin
force-pushed
the
jc/ux-1222-max-message-bytes-infinite
branch
from
80e754f to
e425d66
Compare
malinskibeniamin
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to the topic config editor, both filed under UX-1235.
1. Infinite button on capped configs
The editor offered an Infinite button for every
BYTE_SIZE/DURATIONconfig. For configs with a hard server-side cap (max.message.bytes,segment.bytes), clicking it sent-1, which the broker reinterpreted as4294967295and rejected withINVALID_CONFIG: max.message.bytes 4294967295 is outside of the allowed range [1, 104857600].noInfiniteValueto the config extension schema (ConfigEntryExtensionin Go,ConfigEntryExtendedin TS).max.message.bytesandsegment.bytesinapache_kafka_configs.json.BYTE_SIZE/DURATIONconfigs continue to show the button by default.2. Custom SELECT width
For SELECT configs like
message.timestamp.type, the Custom editor wrapper usedmaxW="fit-content"only.DataSizeSelect/DurationSelecthave intrinsic width from their number+unit inputs, but a bareSingleSelectcollapsed to the width of the current selection — rendering as just an arrow icon, with opened options truncated (CreateTime→Creat,LogAppendTime→LogA).minW="240px"on the Custom value Box so any control has room for its labels.Test plan
max.message.bytes: shows only Default / Custom; KB/MB/GB unit picker still works under Custom.segment.bytes: same — no Infinite button.retention.bytesandretention.ms: unchanged — Infinite still shown and applies-1.message.timestamp.type, click Custom: dropdown is wide enough to showCreateTime/LogAppendTimewithout truncation.cleanup.policyand other non-BYTE/DURATION configs render as before.Follow-up
The JSON config-extension dictionary is hand-curated and drifts from broker truth. Proper fix is to have
DescribeConfigsreturn valid range +supports_infiniteper config. Scoped in the UX-1235 description for a separate ticket.Before on Select Dropdown:
After on Select Dropdown: