proto(sql): nested Column.fields + adopt buf 1.71.0 formatter#2518
Merged
Conversation
Add a repeated Column fields = 3 to the v1alpha3 SQL Column message so composite/struct (json) columns can carry their nested column structure parsed from the engine's structural type. Empty for scalar columns. Regenerates Go, TypeScript, and OpenAPI artifacts.
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / validate (pull_request).
|
CI's buf-action floats to the latest buf (now 1.71.0, released 2026-06-16), whose reformatter collapses single-ref nested option blocks onto one line. The Taskfile's pinned buf (1.65.0) still expanded them, so the validate and proto-generate CI checks demanded opposite formatting and no proto-touching PR could go green. Bump the pinned BUF_VERSION to 1.71.0 and reformat the proto tree so local generation matches CI. buf-action stays unpinned to keep tracking latest.
c-julin
changed the title
malinskibeniamin
approved these changes
Jun 19, 2026
andrewhsu
added a commit
that referenced
this pull request
Jun 23, 2026
PR #2512 pinned the buf CLI in .github/workflows/buf.yml to 1.65.0, but #2518 had already bumped codegen (BUF_VERSION in taskfiles/proto.yaml) to 1.71.0 and reformatted every proto with the 1.71.0 formatter. CI then validated 1.71.0-formatted protos with buf 1.65.0, which re-expands the nested message literals that 1.71.0 collapses, so buf format --diff failed on master across ~30 protos. Bump all three buf-action version pins to 1.71.0 so the CI format check matches the committed protos and the codegen source of truth. Verified locally against current master protos: - buf 1.65.0 format --diff --exit-code: exit 100 (reproduces the failure) - buf 1.71.0 format --diff --exit-code: clean Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
repeated Column fields = 3to the v1alpha3 SQLColumnmessage so composite/struct (json) columns can carry their nested column structure (parsed from the engine's structural type). Empty for scalar columns.BUF_VERSIONto 1.71.0 and reformats the proto tree to match.Why the buf bump is bundled here
CI's
buf-actionis unpinned and floats to the latest buf — now 1.71.0 (released 2026-06-16), whose reformatter collapses single-ref nested option blocks (schema: { json_schema: {...} }) onto one line. The Taskfile was pinned at buf 1.65.0, which still expands them. As a result thevalidate(buf-action) andProto generate(Taskfile) checks demanded opposite formatting, and no proto-touching PR could pass both. This PR was the first to surface it.Fix: bump
BUF_VERSIONintaskfiles/proto.yamlto 1.71.0 and reformat the tree so local generation matches CI.buf-actionis intentionally left unpinned so it keeps tracking the latest buf.Changes
proto/.../v1alpha3/sql.proto: newColumn.fieldstaskfiles/proto.yaml:BUF_VERSION1.65.0 -> 1.71.0Verification
buf 1.71.0 format --exit-codeandbuf lintpasstask proto:generateproduces no diff (generated artifacts match)go buildof the protogen package passesColumn.fieldsis additive (field number 3), backwards-compatibleNo ticket reference.