UX-1338 - Registry updates and misc for the RPCN branch use#2554
UX-1338 - Registry updates and misc for the RPCN branch use#2554SpicyPete wants to merge 2 commits into
Conversation
✅ Clean — no registry drift, off-token colours, or ad-hoc classesApp:
Generated by lookout audit-changes. |
|
@claude review |
|
Claude finished @SpicyPete's task in 5m 22s —— View job Claude PR Review — UX-1338
Overall this is a clean, well-documented PR. The code comments explaining the why (LTR assumption, drag-vs-click threshold, keyboard 🔶 Worth a look1. The old inner wrapper was
If the table was never meant to scroll internally, this is fine as-is — just flagging the changed axis. 2. The devtools now gate on {IsDev && <DebugHelper />}💬 Minor / non-blocking3. PR description vs. code: the body says 4. 5. ✅ Nice work
I did not run |
UX-1338 — Registry updates, shared UI & RPCN bug fixes
Supporting changes split out of the RPCN Visual Editor PR (#2553) to keep that review focused. Merging this first lets #2553 shrink once
masteris pulled back in.Registry & shared UI
use-scroll-shadow.ts— reworked the hook: now takes arefand anorientation('vertical' | 'horizontal', default vertical) and returns{ start, end }edge flags, recomputing on scroll/resize and re-rendering onlywhen an edge actually flips. (API change from the old sentinel-based
useScrollShadow(enabled); the in-repo consumer —DialogBody— is updated here.)drag-scroll-area.tsx(new) — horizontal click-and-drag scroll containerwith alpha edge-fades and keyboard-focus-into-view, built on the hook.
tabs.tsx— addsScrollableTabsList(aTabsListwrapped inDragScrollArea) so an overflowing tab strip drag-scrolls with edge fadesinstead of wrapping.
dialog.tsx—DialogBodygains optional fading top/bottom scroll shadows(
scrollShadow, default on) when its content overflows.dropdown-menu.tsx— addscloseOnClickand deprecatesonSelect(Base UImenu items have no
onSelect; useonClick, addcloseOnClick={false}to keepthe menu open).
AI
ai-elements/prompt-input.tsx— the "Add attachments" menu item now usesonClick+closeOnClick={false}so the menu stays open when the file dialogopens, matching the
dropdown-menuAPI change above.Bug fixes
log-explorer.tsx) — drop the nestedmin-h-0/overflow-autowrappers and scroll the table container directly, sowide log rows no longer overflow / clip the pagination controls.
pipeline-status-toggle.tsx) — aSTARTINGpipeline now stays interactiv to Stopped (matching
STOPPABLE_STATES), rescuing one stuck mid-start; the confirm toast reads""Canceling pipeline start". Only
STOPPINGstays locked while it settles.Adds explicit aria-labels. Covered by a new test.
Dev & config
fixtures (heavy branching, omni-channel platform, resource indirection) for
exercising the pipeline visua
debug-helper/feature-flag-overrides.ts— sort flag keys alphabetically inthe overrides UI.
__root.tsx— gate the TanStack Router devtools onIsDevrather thanprocess.env.NODE_ENV..gitignore— ignore the.tanstack/router temp cache.Testing
bun run type:checkand `bunpipeline-status-toggle.test.tsx(STARTING stays interactive & cancellable;STOPPING stays locked) passes
Risk
Low. Registry files mirror upstream registry components; the only API change
(
useScrollShadow) has its sole in-repo consumer updated in the same PR.