Skip to content

Conversation

@JakeSCahill
Copy link
Contributor

@JakeSCahill JakeSCahill commented Apr 15, 2025

Partially resolves redpanda-data/console#1721

This pull request includes several changes to the console-config-migrator/main.go file, focusing on improving the migration of Kafka and console settings and updating the authentication migration. The most important changes are listed below:

Kafka and Console Settings Migration:

  • Modified migrateKafka function to return serde settings along with Kafka settings and warnings. This change ensures that serde settings from Kafka are correctly merged with console serde settings. [1] [2]
  • Updated Convert function to merge serde settings from both Kafka and console migrations into a single serde block. This ensures that all serde settings are consolidated and correctly applied.

Authentication Migration:

  • Changed the key name from jwtSigningSecret to jwtSigningKey in the migrateAuthentication function.

These changes improve the overall configuration migration process by ensuring that settings are correctly merged and correctly named.

Test case

Paste the following into the migration tool:

kafka:
  broker: "localhost:9092"
  schemaRegistry:
    username: "sruser"
    password: "srpass"
    bearerToken: "srbearer"
    url: "http://schema-registry:8081"
  protobuf:
    enabled: true
  cbor:
    enabled: false
  messagePack:
    enabled: true

You should see:

kafka:
  broker: "localhost:9092"
  sasl:
    enabled: true
    impersonateUser: true
schemaRegistry:
  authentication:
    basic:
      username: sruser
      password: srpass
    bearerToken: srbearer
    impersonateUser: false
  url: "http://schema-registry:8081"
serde:
  protobuf:
    enabled: true
  cbor:
    enabled: false
  messagePack:
    enabled: true

@netlify
Copy link

netlify bot commented Apr 15, 2025

Deploy Preview for docs-ui ready!

Name Link
🔨 Latest commit c56dbd1
🔍 Latest deploy log https://app.netlify.com/sites/docs-ui/deploys/67fe1e607ec72c0008a2ff71
😎 Deploy Preview https://deploy-preview-278--docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@asimms41 asimms41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Migration tool works as described.

@JakeSCahill JakeSCahill merged commit 076fbd5 into main Apr 15, 2025
6 checks passed
@JakeSCahill JakeSCahill deleted the migrator-fixes branch April 15, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serde Protobuf is broken in v3 release

3 participants