-
Notifications
You must be signed in to change notification settings - Fork 47
Document how to disable Pod antiaffinity rules #1303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughAdds documentation to the Kubernetes production deployment guide showing how to disable podAntiAffinity via a Helm values override. Introduces a YAML snippet setting podAntiAffinity: null under statefulset.podTemplate.spec.affinity, notes this enables multiple brokers on a single node, and includes a warning that it is not recommended for production due to data loss risk. No code or logic changes. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
modules/deploy/pages/deployment-option/self-hosted/kubernetes/k-production-deployment.adoc (1)
637-638: Tighten the warning with an operational caveat.Consider adding that disabling anti-affinity can also increase resource contention and reduce availability during rolling updates.
-WARNING: Disabling `podAntiAffinity` rules is not recommended for production environments as it allows multiple brokers to be scheduled on the same node, increasing the risk of data loss if a node fails. +WARNING: Disabling `podAntiAffinity` rules is not recommended for production environments. It allows multiple brokers to be scheduled on the same node, increasing the risk of data loss if a node fails and raising the likelihood of resource contention and reduced availability during maintenance or rolling updates.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
modules/deploy/pages/deployment-option/self-hosted/kubernetes/k-production-deployment.adoc(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - redpanda-docs-preview
- GitHub Check: Header rules - redpanda-docs-preview
- GitHub Check: Pages changed - redpanda-docs-preview
modules/deploy/pages/deployment-option/self-hosted/kubernetes/k-production-deployment.adoc
Show resolved
Hide resolved
modules/deploy/pages/deployment-option/self-hosted/kubernetes/k-production-deployment.adoc
Show resolved
Hide resolved
|
@JakeSCahill this update looks good, but 2 other warnings on this page aren't rendering properly. Can you please fix here and here? |
Thanks Michele. The first one is valid. It's an example warning log. I've fixed the second one. |
micheleRP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Resolves https://redpandadata.atlassian.net/browse/DOC-1388
This pull request adds documentation explaining how to disable
podAntiAffinityrules in Kubernetes deployments, specifically for cases like development environments where running multiple brokers on the same node may be desirable. It also includes a warning about the risks of disabling these rules in production.Key documentation update:
podAntiAffinityin thestatefulsetconfiguration, along with a warning about the risks of doing so in production environments.Page previews
Checks