fix NPE when running /f mod without args #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
markhughes
approved these changes
Jun 11, 2017
Member
markhughes
left a comment
markhughes
left a comment
There was a problem hiding this comment.
Everything is perfect, I will merge this now.
I added some notes about styling changes from the previous maintainers, which we can change in another commit 👍
Thanks for working on this so quickly 🕺
|
|
||
| // Transfer money | ||
| EconomyResponse erw = econ.withdrawPlayer(fromAcc, amount); | ||
| EconomyResponse erw = econ.withdrawPlayer(fromAcc.getName(), amount); |
Member
There was a problem hiding this comment.
I know its not your fault, but the previous maintainer used a lot of acronyms which we're trying to move away from - as these can make it difficult to read.
For example, erw should be ecomomyResponseWithdraw
|
|
||
| if (erw.transactionSuccess()) { | ||
| EconomyResponse erd = econ.depositPlayer(toAcc, amount); | ||
| EconomyResponse erd = econ.depositPlayer(toAcc.getName(), amount); |
Member
There was a problem hiding this comment.
Same as above, move to ecomonyResponseDeposit
|
|
||
| public TextUtil() { | ||
| this.tags = new HashMap<String, String>(); | ||
| this.tags = new HashMap<>(); |
Member
There was a problem hiding this comment.
Perfect!! Diamonds all around 💎💎💎💎
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixed NPE
Had to put a UTF-8 line in gradle as I was getting odd errors.
Vault API updates.