Skip to content

Create the id generator capability for Denmark#45

Merged
SLourenco merged 2 commits intomasterfrom
denmark-generator
Jan 19, 2021
Merged

Create the id generator capability for Denmark#45
SLourenco merged 2 commits intomasterfrom
denmark-generator

Conversation

@SLourenco
Copy link
Copy Markdown
Contributor

@SLourenco SLourenco commented Jan 18, 2021

Proposed Changes

  • Add a new capability: Generate identifiers based on citizen data
  • Add the generator for Denmark

Denmark Generator

  • All digits, expect the 8th and 9th digits, can be directly defined based on the citizen data
  • For the 8th and 9th digits, we must find combinational sum (taking into account the multiplication factors) that makes the id a valid one.

This exposes the generateId method, which will generate a fake identifier based on citizen data
@SLourenco SLourenco added the enhancement New feature or request label Jan 18, 2021
@SLourenco SLourenco requested a review from anbernar January 18, 2021 20:17
@SLourenco SLourenco self-assigned this Jan 18, 2021
@SLourenco
Copy link
Copy Markdown
Contributor Author

@AlexOlival @JoaoFSCruz Please consider if this change should be brought to the php version as well

Comment thread src/main/java/com/github/reducktion/socrates/generator/DenmarkIdGenerator.java Outdated
…IdGenerator.java

Co-authored-by: André Bernardino <11179175+afbernardino@users.noreply.github.com>
@SLourenco SLourenco merged commit dd23ffb into master Jan 19, 2021
@anbernar anbernar deleted the denmark-generator branch March 25, 2021 23:20
anbernar added a commit that referenced this pull request Apr 3, 2022
* Create the id generator capability for Denmark

This exposes the generateId method, which will generate a fake identifier based on citizen data

Co-authored-by: André Bernardino <11179175+afbernardino@users.noreply.github.com>
anbernar added a commit that referenced this pull request Jul 31, 2024
* Create the id generator capability for Denmark

This exposes the generateId method, which will generate a fake identifier based on citizen data

Co-authored-by: André Bernardino <11179175+afbernardino@users.noreply.github.com>
anbernar added a commit that referenced this pull request Jul 31, 2024
* Create the id generator capability for Denmark

This exposes the generateId method, which will generate a fake identifier based on citizen data

Co-authored-by: André Bernardino <11179175+afbernardino@users.noreply.github.com>
anbernar added a commit that referenced this pull request Jul 31, 2024
* Create the id generator capability for Denmark

This exposes the generateId method, which will generate a fake identifier based on citizen data

Co-authored-by: André Bernardino <11179175+anbernar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants