Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for passing JSON-formatted extension parameters to the cp command, renames a conflicting flag in the rm command, and bumps related dependencies and CI configuration.
- Introduce
--ext-params(-X) argument in shared CLI args, parse it intoQueryParams, and wire it throughcp’s query builder. - Rename the remove command’s short flag from
-Tto-tto avoid a conflict with timeout. - Update
reduct-rsto v1.15.0 and switch CI workflow to usevars.MINIMAL_RUST_VERSION.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/parse/widely_used_args.rs | Added make_ext_arg for the new --ext-params flag |
| src/parse/helpers.rs | Extended QueryParams and parsing logic to handle optional ext JSON |
| src/cmd/rm.rs | Renamed remove flag shortcut from -T to -t |
| src/cmd/rm/query_remover.rs | Updated test fixture to include new ext field |
| src/cmd/cp/helpers.rs | Wired query_builder.ext(...) when ext params are present |
| src/cmd/cp.rs | Added the make_ext_arg() to the cp subcommand |
| Cargo.toml | Bumped reduct-rs dependency from 1.14.0 to 1.15.0 |
| .github/workflows/ci.yml | Switched Rust toolchain reference to use vars.MINIMAL_RUST_VERSION |
Comments suppressed due to low confidence (2)
src/cmd/cp/helpers.rs:130
- Add unit or integration tests for the
--ext-paramsflag to verify JSON parsing and confirm thatQueryBuilder.ext(...)is invoked when this parameter is provided.
if let Some(ext) = &query_params.ext {
.github/workflows/ci.yml:69
- Ensure
MINIMAL_RUST_VERSIONis defined undervarsin your repository’s settings or in the workflow; otherwise the CI job will fail to resolve the toolchain.
toolchain: ${{ vars.MINIMAL_RUST_VERSION }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #102
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What was changed?
The PR adds the
--ext-paramsflag to thereduct -cli cpcommand to use extension during copy operations.Additionally. renamed -T to -t shortcut for the --time argument of the remove command to avoid conflict with the -T (timeout).
Related issues
#102
Does this PR introduce a breaking change?
Yes
Other information: