Skip to content
This repository was archived by the owner on Dec 2, 2022. It is now read-only.

Conversation

@mohammedeisa
Copy link
Contributor

This commit contains updates to the sample options page documentation links.

Copy link

@KevinBatdorf KevinBatdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at a few of them but the pages don't exist. Is there a plan to add these pages before this is updated?

(The old pages don't seem to exist either)

$section = array(
'title' => esc_html__( 'Text Area', 'your-textdomain-here' ),
'desc' => esc_html__( 'For full documentation on this field, visit: ', 'your-textdomain-here' ) . '<a href="//docs.redux.io/core/fields/textarea/" target="_blank">//docs.redux.io/core/fields/textarea/</a>',
'desc' => esc_html__( 'For full documentation on this field, visit: ', 'your-textdomain-here' ) . '<a href="https://devs.redux.io/core-fields/textarea.html" target="_blank">//docs.redux.io/core-fields/textarea.html</a>',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one still says docs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-01-22 at 8 42 57 AM

@mohammedeisa
Copy link
Contributor Author

@KevinBatdorf I think you can merge this commit as is and I will fix the undefined and the docs.redux.io ones.
About the inexistent pages, I prefer to keep them until we create pages with the same usage.

@KevinBatdorf
Copy link

Can you create the pages first? Or otherwise add redirects?

Also, I'm not familiar enough with the codebase to be merging.

@mohammedeisa
Copy link
Contributor Author

Can you create the pages first? Or otherwise add redirects?

Also, I'm not familiar enough with the codebase to be merging.

Currently, creating new pages for documentation is not a priority.
The priority is to make the documentation links in the plugin work.

@KevinBatdorf
Copy link

The priority is to make the documentation links in the plugin work.

In general we should never add anything broken to production code. Are all the URLs working now?

@mohammedeisa
Copy link
Contributor Author

@KevinBatdorf It seems that there is something wrong with my IDE.
I found many other docs.redux.io occurrences that replaced them.
I commented out the unexisting documentation links and added links to the old documentation website docsv3.redux.io for the links that don't exist in devs.redux.io temporary until we create the same pages in devs.redux.io

@mohammedeisa mohammedeisa requested a review from dovy February 5, 2021 00:20
@dovy dovy merged commit 407e55c into master Feb 15, 2021
@dovy dovy deleted the develop branch February 15, 2021 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants