Skip to content

Update argument type of reducer produced by combineReducers #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timdorr merged 3 commits into from
Nov 23, 2016
Merged

Update argument type of reducer produced by combineReducers #2115

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7663ccf
update argument type of reducer produced by combineReducers
nickarora Nov 21, 2016
7602804
update Reducer type to use $Shape
nickarora Nov 22, 2016
8912702
define CombinedReducer type
nickarora Nov 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion flow-typed/redux.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ declare module 'redux' {

declare type Reducer<S, A> = (state: S, action: A) => S;

declare type CombinedReducer<S, A> = (state: $Shape<S> & {} | void, action: A) => S;

declare type Middleware<S, A> =
(api: MiddlewareAPI<S, A>) =>
(next: Dispatch<A>) => Dispatch<A>;
Expand All @@ -46,7 +48,7 @@ declare module 'redux' {
declare function bindActionCreators<A, C: ActionCreator<A, any>>(actionCreator: C, dispatch: Dispatch<A>): C;
declare function bindActionCreators<A, K, C: ActionCreators<K, A>>(actionCreators: C, dispatch: Dispatch<A>): C;

declare function combineReducers<O: Object, A>(reducers: O): Reducer<$ObjMap<O, <S>(r: Reducer<S, any>) => S>, A>;
declare function combineReducers<O: Object, A>(reducers: O): CombinedReducer<$ObjMap<O, <S>(r: Reducer<S, any>) => S>, A>;

declare function compose<S, A>(...fns: Array<StoreEnhancer<S, A>>): Function;

Expand Down