Modification to docs/basics/Reducers to make imports more clear. This… #2142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… should help reduce the need to scroll down to the completed code at the bottom of the file, as mentioned in reduxjs#2107
timdorr
requested changes
Dec 9, 2016
Member
timdorr
left a comment
timdorr
left a comment
There was a problem hiding this comment.
Just remove that one section. The rest looks good.
docs/basics/Reducers.md
Outdated
| ``` | ||
|
|
||
| Now we can test our action type for `SET_VISIBILITY_FILTER` and return new, modified state accordingly. | ||
|
|
Member
There was a problem hiding this comment.
These are isolated example bits of code. So imports aren't needed.
timdorr
approved these changes
Dec 9, 2016
Member
|
Thanks! |
Contributor
Author
|
Cool. We should be able to close 2107. |
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
reduxjs#2142) * Modification to docs/basics/Reducers to make imports more clear. This should help reduce the need to scroll down to the completed code at the bottom of the file, as mentioned in reduxjs#2107 * Removed instructions on importing SET_VISIBILITY_FILTER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… should help reduce the need to scroll down to the completed code at the bottom of the file, as mentioned in #2107
This is to address the concerns mentioned in #2107. Specifically, I added some of the missing/assumed import statements into the Basics/Reducers section. If you read the rest of the issue, you'll notice that the original poster's problem has been solved.