Skip to content

Conversation

@chicoxyzzy
Copy link
Contributor

No description provided.

@omnidan
Copy link
Contributor

omnidan commented Oct 22, 2015

Can you explain the reason for this change please? 😃

@chicoxyzzy
Copy link
Contributor Author

the reason is connect accepts 4 arguments actually

@omnidan omnidan changed the title Update UsageWithReact.md Update UsageWithReact.md: connect accepts 4 arguments Oct 22, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small mistakes here (sorry, things like these really bother me 😅):

  • In most cases (remove the common here)
  • ...you will only pass the first argument...
  • missing comma after connect()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure! fixed and rebased

gaearon added a commit that referenced this pull request Oct 22, 2015
Update UsageWithReact.md: `connect` accepts 4 arguments
@gaearon gaearon merged commit 0b598b1 into reduxjs:master Oct 22, 2015
@gaearon
Copy link
Contributor

gaearon commented Oct 22, 2015

Yeah good catch.

@omnidan
Copy link
Contributor

omnidan commented Oct 22, 2015

Thanks @chicoxyzzy 😁 Seems like @gaearon was faster than me this time (I was about to press the button, damn you!)

@chicoxyzzy chicoxyzzy deleted the patch-1 branch October 22, 2015 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants