Skip to content

Fixes: #5 Code Review Xml2XPathObject#11

Merged
redvers merged 2 commits into
mainfrom
code_review_xml2xpathobject
Jan 11, 2026
Merged

Fixes: #5 Code Review Xml2XPathObject#11
redvers merged 2 commits into
mainfrom
code_review_xml2xpathobject

Conversation

@redvers
Copy link
Copy Markdown
Collaborator

@redvers redvers commented Jan 11, 2026

  • Vestigal code removed.
  • Documentation already notes the unsupported data types.
  • There is no facility for logging until later versions of the C library become more common.

- Vestigal code removed.
- Documentation already notes the unsupported data types.
- There is no facility for logging until later versions of the C library become more common.
@redvers
Copy link
Copy Markdown
Collaborator Author

redvers commented Jan 11, 2026

Hi @redvers,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 11.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@redvers redvers merged commit 8799ae9 into main Jan 11, 2026
6 checks passed
github-actions Bot pushed a commit that referenced this pull request Jan 11, 2026
github-actions Bot pushed a commit that referenced this pull request Jan 11, 2026
@redvers redvers deleted the code_review_xml2xpathobject branch January 11, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant