Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
…estions The inline suggestion API (Shell.SetInlineSuggestion) is display-only: it renders ghost text but offers no way to accept it into the buffer. Add the missing input side, mirroring the history autosuggest acceptance model: - inline-suggest-accept: accept the whole suggestion. - inline-suggest-accept-word: accept the next word (forward-word semantics). - forward-char / vi-forward-char fall back to accepting an inline suggestion at end of line when history autosuggest accepted nothing, so an existing binding accepts either kind of ghost text. Acceptance follows the same gate as the display: cursor at line end and the suggestion extending the current line. History autosuggest keeps priority.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 38.33% 39.04% +0.71%
==========================================
Files 59 60 +1
Lines 9516 9606 +90
==========================================
+ Hits 3648 3751 +103
+ Misses 5785 5767 -18
- Partials 83 88 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundles the reviewed open contributions onto
dev, recommitted as signed commits with original authorship preserved.Included
fix(history): return an error from
memory.GetLineon out-of-range index (fix(history): return an error from memory.GetLine on out-of-range index #111, @SAY-5, fixes History panic: runtime error: index out of range [1] with length 1 #110)The in-memory history source now returns
errNegativeIndex/errOutOfRangeIndexinstead of panicking, matching the file-backed source's contract. AllGetLinecallers already treat the error as recoverable.Add a bracketed paste transformer hook (Add a bracketed paste transformer hook #113, @M09Ic)
New exported
Shell.PasteTransformerfield, letting applications rewrite a normalized paste payload before insertion (e.g. replace it with a[Pasted text #1 +6 lines]placeholder). Empty result inserts nothing. Merged with theSetPasteTransformermethod dropped — the bare field matches theSyntaxHighlighter/Completerconvention.Add inline suggestion display API (Add inline suggestion display API #114, @M09Ic)
Shell.SetInlineSuggestion/ClearInlineSuggestion/GetInlineSuggestionrender application-provided ghost text after the cursor (AI predictions, remote completions, …), gated to line-end with a prefix match. History autosuggest keeps priority.feat(inline): commands to accept inline suggestions (new)
Adds the missing input side for the display API:
inline-suggest-accept— accept the whole suggestion.inline-suggest-accept-word— accept the next word.forward-char/vi-forward-charfall back to accepting an inline suggestion at line-end when history autosuggest accepted nothing.Acceptance logic lives in
internal/display; thin*Shellcommand wrappers in the root package.Testing
go build ./...,go vet ./..., andgo test ./...all pass.internal/displayand end-to-end tests in the root package.Wiki updated separately: command reference plus new Inline Suggestions and Bracketed Paste pages.
Closes #110. Supersedes #111, #113, #114.