tmp_squash_msg can be improved

[tanin47]

tmp_squash_msh seems to be hanging around if we use git reflow in other directories than root. This is due to this part of code.

    def append_to_squashed_commit_message(message = '')
      run "echo \"#{message}\" | cat - .git/SQUASH_MSG > ./tmp_squash_msg"
      run 'mv ./tmp_squash_msg .git/SQUASH_MSG'
    end

If we are not the the root directory, the relative ./git won't exist

We can change to something like:

    def append_to_squashed_commit_message(message = '')
     git_root_dir = `echo $(git rev-parse --show-toplevel)`
      run "echo \"#{message}\" | cat - #{git_root_dir}/.git/SQUASH_MSG > #{git_root_dir}/tmp_squash_msg"
      run 'mv #{git_root_dir}/tmp_squash_msg #{git_root_dir}/.git/SQUASH_MSG'
    end

[codenamev]

That's a great idea. Nice catch! Care to submit a pull request? This would
be a great method to have in our git_helpers in lib/git_reflow/git_helpers.rb

On Sunday, May 3, 2015, Tanin Na Nakorn notifications@github.com wrote:

tmp_squash_msh seems to be hanging around if we use git reflow in other
directories than root. This is due to this part of code.

def append_to_squashed_commit_message(message = '')
  run "echo \"#{message}\" | cat - .git/SQUASH_MSG > ./tmp_squash_msg"
  run 'mv ./tmp_squash_msg .git/SQUASH_MSG'
end

If we are not the the root directory, the relative ./git won't exist

We can change to something like:

def append_to_squashed_commit_message(message = '')
 git_root_dir = `echo $(git rev-parse --show-toplevel)`
  run "echo \"#{message}\" | cat - #{git_root_dir}/.git/SQUASH_MSG > #{git_root_dir}/tmp_squash_msg"
  run 'mv #{git_root_dir}/tmp_squash_msg #{git_root_dir}/.git/SQUASH_MSG'
end

—
Reply to this email directly or view it on GitHub
#97.