Fix the ask to open in browser dialog on Mac.#143
Merged
codenamev merged 1 commit intoreenhanced:masterfrom Oct 27, 2015
Merged
Fix the ask to open in browser dialog on Mac.#143codenamev merged 1 commit intoreenhanced:masterfrom
codenamev merged 1 commit intoreenhanced:masterfrom
Conversation
Collaborator
There was a problem hiding this comment.
I think there's an OS.unix? we should use here.
Why: * GitReflow::Sandbox#ask_to_open_in_browser method currently only works for linux. This change addresses the need by: * Add OS.mac? to the initial if statement guarding other platforms.
squaresurf
force-pushed
the
ask-to-open-fix
branch
from
aed5db4 to
e0f5e22
Compare
Contributor
Author
|
@codenamev I've fixed it to use |
Collaborator
|
lgtm |
codenamev
pushed a commit
that referenced
this pull request
Oct 27, 2015
Why: GitReflow::Sandbox#ask_to_open_in_browser method currently only works for linux. This change addresses the need by: Add OS.mac? to the initial if statement guarding other platforms. Close #143 LGTM given by: @codenamev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
for linux.
This change addresses the need by: