Fixing Refresh to take in parameter for "base" instead of "branch"#169
Merged
codenamev merged 1 commit intoreenhanced:masterfrom May 3, 2016
Merged
Fixing Refresh to take in parameter for "base" instead of "branch"#169codenamev merged 1 commit intoreenhanced:masterfrom
codenamev merged 1 commit intoreenhanced:masterfrom
Conversation
simonzhu24
force-pushed
the
sz/naming-bug-fix
branch
from
c73c31f to
bcf0b98
Compare
Contributor
Author
|
@codenamev can we merge this? |
| refresh_options = { | ||
| :remote => options[:remote], | ||
| :branch => options[:branch] | ||
| :base => options[:base] |
Collaborator
There was a problem hiding this comment.
don't you need to update something in update_feature_branch as well?
simonzhu24
force-pushed
the
sz/naming-bug-fix
branch
2 times, most recently
from
081e9db to
b107c9e
Compare
| c.flag [:b,:base], default_value: 'master' | ||
| c.action do |global_options, options, args| | ||
| # usage: git reflow refresh [remote_location - defaults to origin] [base_branch_name - defaults to master] | ||
| # usage: git reflow refresh -r [remote_location - defaults to origin] -b [base_branch_name - defaults to master] |
Collaborator
There was a problem hiding this comment.
The primary advantage of using a gem like gli is that it adds documentation with its syntax. We have a task to add documentation for the code which is where something like this would be better suited to live. I'd still like to see the comments removed here.
simonzhu24
force-pushed
the
sz/naming-bug-fix
branch
from
b107c9e to
89088f5
Compare
Contributor
Author
|
@codenamev Fixed. Please let me know when you have a chance to review! |
Collaborator
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.