fix: exclude .formatted date strategy case on Linux#9
Merged
Conversation
On Linux, swift-foundation (FoundationEssentials) does not define .formatted as an enum case on DateEncodingStrategy/DateDecodingStrategy. Instead, swift-corelibs-foundation provides a static func .formatted() that returns .custom(...), so the .custom case already handles it. Closes #7 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swift-foundation(FoundationEssentials) does not define.formattedas an enum case onDateEncodingStrategy/DateDecodingStrategy. It is guarded by#if FOUNDATION_FRAMEWORKand only exists on Apple platforms.swift-corelibs-foundationprovides astatic func formatted(_ formatter:)that returns.custom(...)as a compatibility shim, so the.customcase already handles it at runtime..formatted(let formatter)switch cases with#if !os(Linux)in bothJSONDecoderImpl.swiftandJSONEncoderImpl.swift.Closes #7
Test plan
Made with Cursor