chore(transport,service): add Debug implementations to network types#56
Merged
Conversation
- Add manual Debug impl to SimContext with port_offset field - Add Debug impls to SimSimplexChannels and SimMarshalChannels - Add Debug impls to SimControl, SimChannels, SimTransportProvider - Add Debug impls to NetworkTransportProvider and NetworkControl - Add Debug impls to SimplexChannels and MarshalChannels in transport - Add Debug impl to NetworkTransport with channel fields - Add Debug impl to TransportBundle with channel fields - Add Debug impl to TransportConfig with backlog field - Add Debug impl to NodeRunContext - Add Debug impl to KoraNodeService - Remove all #[allow(missing_debug_implementations)] suppressions These manual implementations allow proper Debug output while handling non-Debug fields (like channels and oracles) with finish_non_exhaustive().
refcell
commented
Feb 1, 2026
Owner
Author
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
reviewer-gamma review:
LGTM - ready to merge.
Reviewed:
- ✅ All 13 Debug implementations follow correct patterns
- ✅ Uses
finish_non_exhaustive()for types with non-Debug fields (channels, oracles) - ✅ Shows useful debug info (port_offset, backlog, quota) where applicable
- ✅ Generic bounds correctly constrained
- ✅ CI passes (Build, Clippy, Deny, Format, Test)
Clean implementation that removes lint suppressions in favor of proper Debug impls.
refcell
commented
Feb 1, 2026
Owner
Author
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
Code Review: LGTM ✅
This PR adds proper Debug implementations to 13 types across transport and service layers, removing all #[allow(missing_debug_implementations)] suppressions.
Review Summary:
- ✅ All implementations correctly handle generic bounds (
P: PublicKey,E: Clock,C: Signer) - ✅ Proper use of
finish_non_exhaustive()for non-Debug fields (channels, oracles) - ✅ Shows meaningful debug info where applicable (port_offset, quota, backlog)
- ✅ CI clean: 501 tests pass, clippy clean, no warnings
Quality:
- Type-safe implementations with proper where bounds
- Consistent pattern across all types
- Good use of
finish_non_exhaustive()to hide implementation details that can't/shouldn't be debugged
Ready to merge.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds manual Debug implementations to 13 types across the transport and service layers, removing all
#[allow(missing_debug_implementations)]suppressions.Changes
port_offsetandforce_base_addrfinish_non_exhaustive()Testing
✅ All 501 tests pass
✅ clippy clean with -D warnings
✅ No compilation warnings
Type Safety
All implementations: