Conversation
GitHub forces Node 20 actions onto Node 24 with a deprecation notice on every run. Bump to versions whose action.yml declares node24: actions/checkout v5.0.1, actions/setup-python v6.0.0, actions/upload-artifact v6.0.0, actions/download-artifact v7.0.0. upload-artifact flipped the default of include-hidden-files to false in v4.4, so the dotfile path '.coverage' stops being uploaded after the bump. Set include-hidden-files: true on the three steps that upload '.coverage' so the artifacts still land. On macOS runners aws/tap is pre-tapped and brew refuses to load it without explicit trust, printing a multi-line warning on every brew update. cijoe does not use anything from aws/tap, so untap it first. Signed-off-by: Simon A. F. Lund <os@safl.dk>
Coverage Report for CI Build 28375908171Coverage increased (+0.1%) to 77.528%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Ruff F401 flagged 22 dead imports across docs/, src/, and tests/ that accumulated over time as code moved around. Cleared the same way ruff would auto-fix: no exports relied on any of them. While here, fixed an unused 'state' destructuring at cmdrunner.py:65 that pyright had been warning about, and dropped a 'not useful yet' commented rmdir at null_blk.py whose author note dates back several years; git history retains it if anyone wants it back. Signed-off-by: Simon A. F. Lund <os@safl.dk>
Three leftover spots after the workflow-to-task rename: the sphinx sidebar pattern at docs/source/conf.py still excluded 'workflows**' where the renamed directory is 'tasks/'; the example task header in example_task_default.yaml had a 'GitHUB' casing typo; and the bash completion's default filename was the legacy 'cijoe-workflow.yaml' so step-name completion silently failed for users on the new 'cijoe-task.yaml'. Prefer the new name and fall back to the legacy one so completion still works mid-migration. Signed-off-by: Simon A. F. Lund <os@safl.dk>
safl
changed the title
GitHub is migrating the 'macos-latest' label to macOS 26 from June 15, 2026, and emits a migration notice on every macOS run until the move completes. Pin to 'macos-15' (Sequoia) so the image is explicit, the notice is gone, and a runner change doesn't ride in unannounced. The last successful unittest run was on this image; bumping to macos-26 can ride in a separate PR once the migration settles. Signed-off-by: Simon A. F. Lund <os@safl.dk>
Signed-off-by: Simon A. F. Lund <os@safl.dk>
naddinadja
approved these changes
Jun 29, 2026
naddinadja
left a comment
naddinadja
left a comment
Contributor
There was a problem hiding this comment.
lots of good, small fixes! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR rolls four small chores into a v0.9.60 release.
The CI work bumps every action in
verify_and_publish.ymlto a release whoseaction.ymldeclaresnode24, so GitHub stops forcing them onto Node 24 with a deprecation notice on every run. The pins areactions/checkoutto v5.0.1,actions/setup-pythonto v6.0.0,actions/upload-artifactto v6.0.0 andactions/download-artifactto v7.0.0. Earlier versions in the v5/v6 line of the artifact actions still ship Node 20, so they were ruled out.actions/upload-artifactflipped the default ofinclude-hidden-filestofalsein v4.4, which silently drops dotfile paths like.coverage; the three steps that upload.coverageget an explicitinclude-hidden-files: true. On macOS runners the image now pre-tapsaws/tap, which Homebrew refuses to load without explicit trust and prints a multi-line warning on everybrew update; cijoe pulls nothing fromaws/tap, so eachbrew updateis preceded bybrew untap aws/tap || true.The tech-debt pass drops 22 unused imports flagged by ruff F401 across
docs/,src/, andtests/, fixes an unusedstatedestructuring atsrc/cijoe/core/scripts/cmdrunner.py:65, and removes three lines of commented-out dead code insrc/cijoe/linux/null_blk.py.The post-rename cleanup resolves three leftover references to "workflow" after the recent rename to "task": the Sphinx sidebar pattern in
docs/source/conf.pyexcluded a directory that no longer exists, the example task header had a "GitHUB" casing typo, and the bash completion's default filename was the legacycijoe-workflow.yamlso step-name completion silently failed once users moved tocijoe-task.yaml. It now prefers the new name and falls back to the legacy one for users mid-migration.Closes with a version bump to v0.9.60 via the same two-file pattern as prior bumps (
src/cijoe/core/__init__.pyand.github/workflows/cijoe_docker.yml).Test plan
Watch
verify_and_publishgo green on this PR, including the macOS legs ofunittestwhere the brew warning originated. Confirm thepublish-coveragejob finds.coverageartifacts to combine, and inspect a macOS unittest log to confirm the aws/tap warning and Node 20 deprecation note are gone.