Skip to content

Hot fix // mesh vanishing problem #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
refiaa merged 4 commits into from
Oct 21, 2024
Merged

Hot fix // mesh vanishing problem #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
434d97a
bug hotfix
refiaa Oct 21, 2024
bf6468f
revert login enhanced
refiaa Oct 21, 2024
e0d6be2
Version and GUI name
refiaa Oct 21, 2024
b757a2e
README
refiaa Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
233 changes: 170 additions & 63 deletions Editor/DecimaterMain.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public static void ShowWindow()
{
GetWindow<DecimaterMain>("Mesh Optimizer GUI");
}

private void OnEnable()
{
LoadShaders();
Expand Down Expand Up @@ -71,11 +71,7 @@ private void OnGUI()
decimateLevel = EditorGUILayout.Slider("Optimize Level", decimateLevel, 0.1f, 1.0f);
if (EditorGUI.EndChangeCheck())
{
Mesh currentMesh = GetCurrentMesh();
if (currentMesh != null)
{
MeshRevertManager.StoreDecimateLevel(currentMesh, decimateLevel);
}
// NOTHING HERE
}

GUILayout.Space(10);
Expand All @@ -84,12 +80,12 @@ private void OnGUI()
ApplyDecimation();
}

if (GUILayout.Button("Revert"))
if (GUILayout.Button("Undo"))
{
RevertDecimation();
}

if (GUILayout.Button("Revert to Original"))
if (GUILayout.Button("Reset To Original Mesh"))
{
RevertToOriginalMesh();
}
Expand All @@ -101,15 +97,41 @@ private void OnGUI()
private void ApplyDecimation()
{
bool isSkinnedMeshRenderer = selectedGameObject.GetComponent<SkinnedMeshRenderer>() != null;
int boneCount = 0;

if (isSkinnedMeshRenderer)
{
SkinnedMeshRenderer skinnedMeshRenderer = selectedGameObject.GetComponent<SkinnedMeshRenderer>();
boneCount = skinnedMeshRenderer.bones.Length;
}

EnableReadWrite(decimatedMesh);
MeshDecimaterUtility.DecimateMesh(originalMesh, decimatedMesh, decimateLevel, isSkinnedMeshRenderer, originalSubmeshCount);
EnableReadWrite(originalMesh);

// save "level" to history
MeshRevertManager.PushDecimateLevel(originalMesh, decimateLevel);

MeshDecimaterUtility.DecimateMesh(originalMesh, decimatedMesh, decimateLevel, isSkinnedMeshRenderer, originalSubmeshCount, boneCount);

decimatedMesh.RecalculateNormals();
decimatedMesh.RecalculateBounds();

SaveDecimatedMesh();

MeshRevertManager.StoreOriginalMesh(decimatedMesh, originalMesh);

MeshRevertManager.StoreDecimateLevel(decimatedMesh, decimateLevel);
EditorApplication.delayCall += () =>
{
ApplyMeshToRenderer(isSkinnedMeshRenderer);
};

meshPreviewer.UpdatePreviewMesh(selectedGameObject);

isFirstDecimation = false;
}

private void ApplyMeshToRenderer(bool isSkinnedMeshRenderer)
{
if (selectedGameObject == null) return;

if (selectedGameObject.GetComponent<MeshFilter>() != null)
{
Expand All @@ -121,43 +143,71 @@ private void ApplyDecimation()
else if (isSkinnedMeshRenderer)
{
SkinnedMeshRenderer skinnedMeshRenderer = selectedGameObject.GetComponent<SkinnedMeshRenderer>();

skinnedMeshRenderer.sharedMesh = null;

skinnedMeshRenderer.sharedMesh = decimatedMesh;
skinnedMeshRenderer.sharedMaterials = originalMaterials;

skinnedMeshRenderer.updateWhenOffscreen = true;

Animator animator = selectedGameObject.GetComponent<Animator>();
if (animator != null)
{
animator.Rebind();
}

ValidateBoneWeights(skinnedMeshRenderer);
}
}

meshPreviewer.UpdatePreviewMesh(selectedGameObject);
private void ValidateBoneWeights(SkinnedMeshRenderer skinnedMeshRenderer)
{
Mesh mesh = skinnedMeshRenderer.sharedMesh;
int boneCount = skinnedMeshRenderer.bones.Length;

// errorめんどいの
if (isFirstDecimation)
for (int i = 0; i < mesh.boneWeights.Length; i++)
{
isFirstDecimation = false;
Debug.LogWarning("First decimation performed. Applying decimation again to prevent mesh data mismatch error.");
ApplyDecimation();
BoneWeight bw = mesh.boneWeights[i];
if (bw.boneIndex0 >= boneCount || bw.boneIndex1 >= boneCount || bw.boneIndex2 >= boneCount || bw.boneIndex3 >= boneCount)
{
Debug.LogError($"Invalid bone index detected in boneWeights at vertex {i}: boneIndex0={bw.boneIndex0}, boneIndex1={bw.boneIndex1}, boneIndex2={bw.boneIndex2}, boneIndex3={bw.boneIndex3}");
}
}
}

private void RevertDecimation()
{
if (selectedGameObject.GetComponent<MeshFilter>() != null)
if (originalMesh == null)
{
MeshFilter meshFilter = selectedGameObject.GetComponent<MeshFilter>();
meshFilter.sharedMesh = originalMesh;
MeshRenderer meshRenderer = selectedGameObject.GetComponent<MeshRenderer>();
meshRenderer.sharedMaterials = originalMaterials;
Debug.LogWarning("Original mesh not found.");
return;
}
else if (selectedGameObject.GetComponent<SkinnedMeshRenderer>() != null)

float? previousDecimateLevel = MeshRevertManager.RevertDecimateLevel(originalMesh);
if (previousDecimateLevel.HasValue)
{
SkinnedMeshRenderer skinnedMeshRenderer = selectedGameObject.GetComponent<SkinnedMeshRenderer>();
skinnedMeshRenderer.sharedMesh = originalMesh;
skinnedMeshRenderer.sharedMaterials = originalMaterials;
}
decimateLevel = previousDecimateLevel.Value;
MeshRevertManager.PushDecimateLevel(originalMesh, decimateLevel);

decimateLevel = DEFAULT_DECIMATE_LEVEL;
MeshRevertManager.StoreDecimateLevel(originalMesh, decimateLevel);
ApplyDecimation();

meshPreviewer.UpdatePreviewMesh(selectedGameObject);
Debug.Log($"Reverted to previous decimate level: {decimateLevel}");
}
else
{
if (decimateLevel == DEFAULT_DECIMATE_LEVEL)
{
EditorUtility.DisplayDialog("Revert Failed", "Not able to revert. Already at the default decimate level.", "OK");
}
else
{
EditorUtility.DisplayDialog("Revert Failed", "Nothing to revert.", "OK");
}
Debug.LogWarning("Revert failed: No previous decimate level available.");
}

isFirstDecimation = true;
meshPreviewer.UpdatePreviewMesh(selectedGameObject);
}

private void RevertToOriginalMesh()
Expand Down Expand Up @@ -188,15 +238,15 @@ private void RevertToOriginalMesh()
Debug.Log("Reverted to original mesh.");

decimateLevel = DEFAULT_DECIMATE_LEVEL;
MeshRevertManager.StoreDecimateLevel(originalMeshFromManager, decimateLevel);
MeshRevertManager.PushDecimateLevel(originalMeshFromManager, decimateLevel);
meshInfoDisplay.SetOriginalMesh(originalMeshFromManager);
}
else
{
Debug.LogWarning("Original mesh not found.");

decimateLevel = DEFAULT_DECIMATE_LEVEL;
MeshRevertManager.StoreDecimateLevel(currentMesh, decimateLevel);
MeshRevertManager.PushDecimateLevel(currentMesh, decimateLevel);
meshInfoDisplay.SetOriginalMesh(currentMesh);
}

Expand All @@ -219,18 +269,34 @@ private void UpdateSelection(GameObject newSelectedGameObject)

if (newSelectedGameObject != null)
{
MeshFilter meshFilter = newSelectedGameObject.GetComponent<MeshFilter>();
SkinnedMeshRenderer skinnedMeshRenderer = newSelectedGameObject.GetComponent<SkinnedMeshRenderer>();

if (meshFilter != null)
Mesh original = GetOriginalMesh(newSelectedGameObject);
if (original != null)
{
selectedGameObject = newSelectedGameObject;
originalMesh = meshFilter.sharedMesh;
originalMesh = original;
EnableReadWrite(originalMesh);

decimateLevel = MeshRevertManager.GetDecimateLevel(originalMesh);

decimatedMesh = Instantiate(originalMesh);
string actualMeshName = GetActualMeshName();
string originalPath = AssetDatabase.GetAssetPath(originalMesh);
string directory = Path.GetDirectoryName(originalPath);
string newFileName = $"{actualMeshName}{MESH_SUFFIX}.asset";
string newPath = $"{directory}/{newFileName}";

Mesh existingDecimatedMesh = AssetDatabase.LoadAssetAtPath<Mesh>(newPath);
if (existingDecimatedMesh != null)
{
decimatedMesh = existingDecimatedMesh;
}
else
{
decimatedMesh = new Mesh();
decimatedMesh.name = $"{actualMeshName}{MESH_SUFFIX}";
AssetDatabase.CreateAsset(decimatedMesh, newPath);
AssetDatabase.SaveAssets();
}

meshInfoDisplay.SetOriginalMesh(originalMesh);

Renderer renderer = newSelectedGameObject.GetComponent<Renderer>();
Expand All @@ -245,29 +311,36 @@ private void UpdateSelection(GameObject newSelectedGameObject)
Debug.Log($"Selected Mesh: {AssetDatabase.GetAssetPath(originalMesh)}");
Repaint();
}
else if (skinnedMeshRenderer != null)
{
selectedGameObject = newSelectedGameObject;
originalMesh = skinnedMeshRenderer.sharedMesh;
EnableReadWrite(originalMesh);

decimateLevel = MeshRevertManager.GetDecimateLevel(originalMesh);

decimatedMesh = Instantiate(originalMesh);
meshInfoDisplay.SetOriginalMesh(originalMesh);
}
}

originalMaterials = skinnedMeshRenderer.sharedMaterials;
originalSubmeshCount = new int[originalMesh.subMeshCount];
for (int i = 0; i < originalMesh.subMeshCount; i++)
{
originalSubmeshCount[i] = originalMesh.GetTriangles(i).Length / 3;
}
private Mesh GetOriginalMesh(GameObject gameObject)
{
MeshFilter meshFilter = gameObject.GetComponent<MeshFilter>();
if (meshFilter != null && meshFilter.sharedMesh != null)
{
Mesh mesh = meshFilter.sharedMesh;
if (mesh.name.EndsWith(MESH_SUFFIX))
{
Mesh original = MeshRevertManager.GetOriginalMesh(mesh);
return original != null ? original : mesh;
}
return mesh;
}

Selection.activeObject = originalMesh;
Debug.Log($"Selected Mesh: {AssetDatabase.GetAssetPath(originalMesh)}");
Repaint();
SkinnedMeshRenderer skinnedMeshRenderer = gameObject.GetComponent<SkinnedMeshRenderer>();
if (skinnedMeshRenderer != null && skinnedMeshRenderer.sharedMesh != null)
{
Mesh mesh = skinnedMeshRenderer.sharedMesh;
if (mesh.name.EndsWith(MESH_SUFFIX))
{
Mesh original = MeshRevertManager.GetOriginalMesh(mesh);
return original != null ? original : mesh;
}
return mesh;
}

return null;
}

private void SaveDecimatedMesh()
Expand All @@ -277,7 +350,13 @@ private void SaveDecimatedMesh()
string originalPath = AssetDatabase.GetAssetPath(originalMesh);
string directory = Path.GetDirectoryName(originalPath);
string newFileName = $"{actualMeshName}{MESH_SUFFIX}.asset";
string newPath = Path.Combine(directory, newFileName);

if (actualMeshName.EndsWith(MESH_SUFFIX))
{
newFileName = $"{RemoveDecimatedSuffix(actualMeshName)}{MESH_SUFFIX}.asset";
}

string newPath = $"{directory}/{newFileName}";

Mesh existingMesh = AssetDatabase.LoadAssetAtPath<Mesh>(newPath);
if (existingMesh != null)
Expand All @@ -288,6 +367,7 @@ private void SaveDecimatedMesh()
}
else
{
decimatedMesh.name = $"{RemoveDecimatedSuffix(actualMeshName)}{MESH_SUFFIX}";
AssetDatabase.CreateAsset(decimatedMesh, newPath);
AssetDatabase.SaveAssets();
Debug.Log($"Decimated mesh saved: {newPath}");
Expand All @@ -303,18 +383,42 @@ private string GetActualMeshName()
MeshFilter meshFilter = selectedGameObject.GetComponent<MeshFilter>();
if (meshFilter != null && meshFilter.sharedMesh != null)
{
return meshFilter.sharedMesh.name;
return RemoveCloneAndDecimatedSuffix(meshFilter.sharedMesh.name);
}

SkinnedMeshRenderer skinnedMeshRenderer = selectedGameObject.GetComponent<SkinnedMeshRenderer>();
if (skinnedMeshRenderer != null && skinnedMeshRenderer.sharedMesh != null)
{
return skinnedMeshRenderer.sharedMesh.name;
return RemoveCloneAndDecimatedSuffix(skinnedMeshRenderer.sharedMesh.name);
}

return "Unknown";
}

private string RemoveCloneAndDecimatedSuffix(string meshName)
{
// erase "(Clone)"
if (meshName.EndsWith("(Clone)"))
{
meshName = meshName.Substring(0, meshName.Length - "(Clone)".Length);
}
// erase "_decimated"
if (meshName.EndsWith(MESH_SUFFIX))
{
meshName = meshName.Substring(0, meshName.Length - MESH_SUFFIX.Length);
}
return meshName;
}

private string RemoveDecimatedSuffix(string meshName)
{
if (meshName.EndsWith(MESH_SUFFIX))
{
return meshName.Substring(0, meshName.Length - MESH_SUFFIX.Length);
}
return meshName;
}

private Mesh GetCurrentMesh()
{
if (selectedGameObject != null)
Expand All @@ -339,8 +443,11 @@ private void EnableReadWrite(Mesh mesh)
ModelImporter modelImporter = AssetImporter.GetAtPath(path) as ModelImporter;
if (modelImporter != null)
{
modelImporter.isReadable = true;
AssetDatabase.ImportAsset(path, ImportAssetOptions.ForceUpdate);
if (!modelImporter.isReadable)
{
modelImporter.isReadable = true;
AssetDatabase.ImportAsset(path, ImportAssetOptions.ForceUpdate);
}
}
}

Expand Down
Loading