canUserAdminRepo - Support new UI#240
Conversation
canUserAdminRepo - Support view view
canUserAdminRepo - Support view viewcanUserAdminRepo - Support new UI
SunsetTechuila
left a comment
There was a problem hiding this comment.
Doesn't work if the settings entry is in the dropdown menu
|
Yeah this PR makes sense on its own but probably the whole function should be deprecated instead. In Refined GitHub we now use th API for this purpose. @dnicolson can you look at other deprecated functions and do the same for this one? You can keep the changes so far. |
|
|
Maybe we should re-export it with a different name, as it can still be useful. For example, we can use it for refined-github/refined-github#8553 to decide what to fetch: public members or collaborators |
|
Users seeing that errors see it because they aren't members. Adding this check could hide the error, but nothing else. Also I think external collaborators aren't covered (no settings tab) |
|
I'm not sure we understood each other. This is what I'm talking about: const collaborators = pageDetect.canUserAdminRepo() ? fetchCollaborators() : fetchPublicMemebers();
They are |
|
If "fetch public member" works, that's ok I guess. It won't cover all collaborators but probably better than nothing. Please open a new PR to deprecate this and rename it. |

No description provided.