Skip to content

Document CSS-only features#9283

Merged
fregante merged 6 commits into
mainfrom
copilot/add-comments-test-urls-css
Apr 30, 2026
Merged

Document CSS-only features#9283
fregante merged 6 commits into
mainfrom
copilot/add-comments-test-urls-css

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 26, 2026

.

Copilot AI linked an issue Apr 26, 2026 that may be closed by this pull request
4 tasks
…gh-feature-descriptions

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/bba62c9f-4d5c-4274-a4b5-a3c20f204937

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
Copilot AI changed the title [WIP] Add comments and test URLs to global CSS file Document CSS-only features in readme and add validateReadme check Apr 26, 2026
Copilot AI requested a review from fregante April 26, 2026 08:19
@SunsetTechuila
Copy link
Copy Markdown
Member

SunsetTechuila commented Apr 26, 2026

Why not make them regular disableable features instead?

@fregante
Copy link
Copy Markdown
Member

Unnecessary overhead for things that shouldn't really need to be disabled. Like night-not-found.

If a feature is controversial we make it disableable, otherwise we don't

@github-actions github-actions Bot added the meta Related to Refined GitHub itself label Apr 30, 2026
Comment thread readme.md Outdated
Comment thread readme.md Outdated
Comment thread readme.md Outdated
Comment thread readme.md Outdated
Comment thread readme.md Outdated
Comment thread readme.md Outdated
Comment thread readme.md Outdated
Comment thread readme.md Outdated
Comment thread readme.md Outdated
…ons, rename center-reactions-popup

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/9893b827-4158-4b08-bfc8-3be7d67437ad

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
Copilot AI requested a review from fregante April 30, 2026 10:40
@fregante fregante marked this pull request as ready for review April 30, 2026 10:47
@fregante
Copy link
Copy Markdown
Member

@copilot resolve conflicts, clean-conversations was dropped.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 30, 2026

@copilot resolve conflicts, clean-conversations was dropped.

Done in eb65da6 — rebased onto main and removed all clean-conversations references from readme.md and features.test.ts.

@fregante fregante force-pushed the copilot/add-comments-test-urls-css branch from eb65da6 to 44ca765 Compare April 30, 2026 12:14
@fregante fregante changed the title Document CSS-only features in readme and add validateReadme check Document CSS-only features Apr 30, 2026
@fregante fregante merged commit 34ba42c into main Apr 30, 2026
13 checks passed
@fregante fregante deleted the copilot/add-comments-test-urls-css branch April 30, 2026 12:51
Comment thread build/readme-parser.ts
css: existsSync(`source/features/${simpleId}.css`) || undefined,
css: hasCss || undefined,
// `undefined` hides the key for features that have a .tsx file
cssOnly: (hasCss && !hasTsx) || undefined,
Copy link
Copy Markdown
Member

@fregante fregante Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could have used css: true | "only" | undefined as the type, to drop the dedicated cssOnly key :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Related to Refined GitHub itself

Development

Successfully merging this pull request may close these issues.

Add comments and test URLs to global CSS file

3 participants