-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Heroku support, including using dragonfly-s3_data_store only when needed. #2861
Conversation
parndt
commented
Jan 26, 2015
Now, it gets added in place of fog when you specify `--heroku` while installing. For example: rails new application_name -d postgresql --heroku my-heroku-app This fixes #2859
For a little bit you can see the app at https://testing-refinery-stuff.herokuapp.com |
seed is not loaded, is that ok? |
@simi that is NOT okay! We should load the seed. Do you want to handle that? Or should I? |
1080011
to
4f8c298
Compare
3fab728
to
90c565a
Compare
|
||
# If you are using Redis but not Resque, change this | ||
if defined?(Resque) | ||
Resque.redis = ENV["OPENREDIS_URL"] || "redis://127.0.0.1:6379" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can omit this. There's no benefit using Resque or Redis for clean RefineryCMS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we probably don't need it.
You can see the result of this live at https://testing-refinery-stuff.herokuapp.com username and password are both |
I'm done with this, it's all up to CI now. |
This advice from Heroku is why it's Puma, by the way. |
# Fog allows you to use S3 assets (added for Heroku) | ||
gem 'fog' | ||
group :production do | ||
# Fog allows you to use S3 assets (added for Heroku) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outdated comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, definitely outdated, it should replace the word Fog
with Dragonfly's S3 Data Store extension
Are you able to send a PR against this branch?
The PR title is a bit misleading since you've just moved dragonfly-s3_data_store as opposed to removing it. |
@gwagener fixed that for you 💜 |
👍 🌟 |
Improved Heroku support, including using dragonfly-s3_data_store only when needed.
🎊 |