feat: use webcrypto API to support edge runtimes#384
Merged
Conversation
roncohen
commented
Mar 23, 2025
Contributor
Author
|
since this changes flag evaluation to async, the Node SDK need to be updated separately to also use async when calling |
Contributor
|
Is the purpose of this to support the local evaluation in react and browser SDK? If we want to avoid the need for breaking the backwards compatibility for NodeSDK we can have 2 different implementations (sync and async) theoretically. |
Contributor
Author
|
apologies, i did not write a good enough PR description. To make the NodeSDK work in edge runtimes, like Vercel's or Cloudflare's we can't use |
matus-vacula
approved these changes
Mar 25, 2025
Contributor
matus-vacula
left a comment
matus-vacula
left a comment
There was a problem hiding this comment.
Ah ok, that's what you meant by edge runtimes. I didn't know they use they different runtimes.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 28, 2025
In #384 I made the interface async, that is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
digestis async, we need to update the interface to be async.