feat(vue-sdk): make additional options available#430
Merged
Conversation
use the new style because it unlocks defineProps using a type which means better maintainability.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Vue SDK to use <script setup> style, extracts shared types and hooks into standalone files, and makes additional compiler definitions available.
- Switch to
script setupand splitindex.tslogic intoBucketProvider.vue,hooks.ts,types.ts, andversion.ts - Update
tsconfig.jsonto include declaration files undersrc - Add
SDK_VERSIONand export it for use in the provider
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Expand include to capture *.d.ts files |
| src/version.ts | Extract SDK_VERSION constant |
| src/types.ts | Define shared types for features and provider props |
| src/index.ts | Slim down plugin entry point and re-export new modules |
| src/hooks.ts | Extract Vue composable hooks |
| src/BucketProvider.vue | Migrate provider to <script setup>, use withDefaults |
| dev/plain/components/Events.vue | Example component subscribing to SDK events |
Swiftwork
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move to <script setup> style: use the new style because it unlocks defineProps using a type which means better maintainability.