feat: Make push the default node-sdk sync mode#615
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Node SDK to use SSE-based “push” synchronization for flag definitions by default, adjusting docs and tests accordingly and documenting the release via changesets.
Changes:
- Switch default
flagsSyncModefrom"polling"to"push"(with deprecatedcacheStrategymapping preserved). - Update README/types/docs and examples to reflect the new default behavior.
- Expand tests to assert default
"push"mode behavior and validate deprecatedcacheStrategymappings.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/node-sdk/src/client.ts | Changes default sync mode selection logic to prefer "push". |
| packages/node-sdk/src/types.ts | Updates ClientOptions.flagsSyncMode doc comment to indicate "push" is default. |
| packages/node-sdk/test/client.test.ts | Updates tests for new default and adds coverage for deprecated cacheStrategy mapping. |
| packages/node-sdk/examples/express/reflag.ts | Removes explicit flagsSyncMode: "push" since it’s now the default. |
| packages/node-sdk/README.md | Updates narrative and options table to reflect "push" as default. |
| .changeset/node-sdk-push-default.md | Changeset documenting the Node SDK default sync mode change. |
| .changeset/openfeature-node-provider-push-default.md | Changeset claiming a dependency update for the OpenFeature node provider. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.