fix: resolve all Playwright E2E test failures#444
Merged
itskai-dev merged 1 commit intomainfrom Feb 10, 2026
Merged
Conversation
…b selectors
- Fix agent-profile: use heading level 1 directly (avoid .or() strict mode)
- Fix navigation: use getByRole('heading') for sign-in (avoid .or() ambiguity)
- Fix skill-detail: use exact heading match for Reviews, use main locator
- Fix mcp-detail: use getByRole('button') instead of getByRole('tab') for custom Tabs component
- Fix search: use URL query params for reliable search, button role for filter tabs
- All 27 tests now pass
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 7 failing E2E tests from #443. All 27 tests now pass.
Root causes & fixes:
Strict mode violations — Several locators using
.or()resolved to multiple elements. Fixed by using more specific selectors (exact heading matches,.first()where appropriate).Custom Tabs component — The app uses a custom Tabs component (not Radix) that renders
<button>elements withoutrole="tab". ChangedgetByRole('tab')→getByRole('button')for MCP install tabs and search filter tabs.Search reliability — Changed search tests to use URL query params (
/search?q=memory) instead of typing + debounce, which is more reliable in CI.Test results