fix: done_criteria .min(1) conflicts with .optional().default([])#554
Merged
itskai-dev merged 1 commit intomainfrom Mar 1, 2026
Merged
fix: done_criteria .min(1) conflicts with .optional().default([])#554itskai-dev merged 1 commit intomainfrom
itskai-dev merged 1 commit intomainfrom
Conversation
The .min(1) check on done_criteria ran after .default([]) provided an empty array, causing all minimal task creation to fail with 'Array must contain at least 1 element(s)' even after PR #549 relaxed the schema. Also updates tests: - reflection-origin-gate: use status=doing to test gate (todo tasks skip quality checks via early return) - modules: update schema enforcement tests to match relaxed onboarding behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #549 made
done_criteriaoptional with.optional().default([]), but left.min(1)on the array. Zod runs.min(1)after.default([]), so the default empty array immediately fails validation. Result:POST /tasks {"title": "My first task"}still returns 400.This means the onboarding fix from #549 doesn't actually work — new users still can't create tasks with just a title.
Fix
.min(1)fromdone_criteria— the definition-of-ready check already validates criteria quality for non-todo tasksreflection-origin-gate.test.ts: rejection tests usestatus: 'doing'since todo tasks skip quality checks via early returnmodules.test.ts: schema tests match relaxed onboarding behaviorTesting
tsc --noEmit: 0 errorsRelated