fix: bootstrap heartbeat uses request host instead of hardcoded localhost#564
Merged
itskai-dev merged 1 commit intomainfrom Mar 1, 2026
Merged
fix: bootstrap heartbeat uses request host instead of hardcoded localhost#564itskai-dev merged 1 commit intomainfrom
itskai-dev merged 1 commit intomainfrom
Conversation
…alhost The bootstrap heartbeat template hardcoded 127.0.0.1:4445 in all generated curl commands. On Fly.io or any non-localhost deploy, the generated HEARTBEAT.md was useless — agents couldn't reach the server at that address. Now uses x-forwarded-proto/host headers (set by reverse proxies like Fly.io) with fallback to request Host header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GET /bootstrap/heartbeat/:agentgenerates HEARTBEAT.md with hardcodedcurl http://127.0.0.1:4445/heartbeat/.... On Fly.io or any remote deploy, these URLs are unreachable. A real user onreflectt-evi.fly.devgets a heartbeat doc pointing at localhost.Fix
Derive base URL from
x-forwarded-proto/x-forwarded-hostheaders (set by Fly.io, Vercel, nginx, etc.) with fallback toHostheader.Result:
curl https://reflectt-evi.fly.dev/heartbeat/myagent— correct for any deployment.Testing
tsc --noEmit: 0 errors