Skip to content

don't use foreach directly #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adhami3310 wants to merge 1 commit into from
Closed

don't use foreach directly #33

adhami3310 wants to merge 1 commit into from

Conversation

@adhami3310
Copy link
Member

@adhami3310 adhami3310 commented Jan 18, 2025

No description provided.

@Lendemor
Copy link

Lendemor commented Jan 20, 2025

For all other components we're using the syntax CompName.create() when instancing them internally, why do it differently for Foreach in particular?

@adhami3310
Copy link
Member Author

adhami3310 commented Jan 20, 2025

because foreach is being removed as a component (by me)

@adhami3310
Copy link
Member Author

adhami3310 commented Apr 2, 2025

decided it's prob better to keep upstream working as usual

@adhami3310 adhami3310 closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adhami3310 @Lendemor