-
Notifications
You must be signed in to change notification settings - Fork 230
ENG-8395: Add logos to the templates page #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Greptile OverviewGreptile SummaryThis PR adds integration logos to the templates page. The changes include:
Issue Found:
Confidence Score: 3/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Gallery as Gallery Page
participant Apps as Apps Page
participant Metadata as Template Metadata
participant FileSystem as SVG Files
User->>Gallery: View /templates
Gallery->>Metadata: Load template metadata
Metadata-->>Gallery: Return integrations array
Gallery->>Gallery: Call integration_image() for each
Gallery->>FileSystem: Request /integrations/{light|dark}/{name}.svg
alt SVG exists
FileSystem-->>Gallery: Return SVG
Gallery->>User: Display logo with tooltip
else SVG missing (AGGrid, Slack)
FileSystem-->>Gallery: 404 Not Found
Gallery->>User: Display broken image
end
User->>Apps: Click template
Apps->>Metadata: Load template details
Metadata-->>Apps: Return integrations array
Apps->>Apps: Call integration_image() for each
Apps->>FileSystem: Request /integrations/{light|dark}/{name}.svg
alt SVG exists
FileSystem-->>Apps: Return SVG
Apps->>User: Display logos in header
else SVG missing
FileSystem-->>Apps: 404 Not Found
Apps->>User: Display broken image
end
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18 files reviewed, 1 comment
tgberkeley
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.