Skip to content

Fix missing success pages and improve UI#1719

Merged
Alek99 merged 4 commits intomainfrom
fix-missing-success-pages
Jan 10, 2026
Merged

Fix missing success pages and improve UI#1719
Alek99 merged 4 commits intomainfrom
fix-missing-success-pages

Conversation

@Alek99
Copy link
Copy Markdown
Member

@Alek99 Alek99 commented Jan 10, 2026

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 10, 2026

Greptile Overview

Greptile Summary

This PR improves two success pages by replacing markdown-based content with modern Reflex components and making them discoverable by changing add_as_page from False to True.

Changes Made

UI Improvements

  • check_your_email_demo.py (/thank-you): Replaced markdown_with_shiki() with styled rx.heading() and rx.text() components
  • meeting_successfully_booked.py (/meeting-successfully-booked): Same UI modernization approach
  • Both pages now use gradient headings and improved typography for better visual appeal
  • Added "Home" buttons for navigation back to the main page
  • Adjusted container height from h-[80vh] to h-[60vh]
  • Added responsive padding with p-4

Page Discoverability

  • Changed add_as_page=True in both files, making these pages part of the app's route system
  • These pages were previously hidden (add_as_page=False) but are now accessible

Observations

The implementation is clean and follows existing patterns from the webpage template. However:

  1. Minor CSS inefficiency: Both pages use gap-x-4 in the button container despite having only one button. This class adds horizontal spacing between flex items but has no effect with a single child.

  2. Consistency consideration: Similar success pages like /booked and /to-be-booked offer two action buttons ("Home" and "Installation"), providing users with more next-step options. This PR uses only one button, which may be intentional based on the specific user journey but differs from the established pattern.

The changes successfully address the PR's stated goals of fixing missing success pages and improving UI.

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - changes are limited to UI improvements on success pages with no logic changes.
  • Score of 4/5 reflects straightforward UI improvements with no business logic changes, proper use of existing patterns, and only minor style inefficiencies. The changes successfully modernize two success pages by replacing markdown with component-based UI. No security concerns, error handling issues, or breaking changes. The one point deduction is for the unnecessary gap-x-4 CSS class on single-button containers, which is a non-critical style issue.
  • No files require special attention - both files contain simple, safe UI improvements

Important Files Changed

File Analysis

Filename Score Overview
pcweb/pages/check_your_email_demo.py 4/5 Improved UI from markdown to components, made page discoverable. Contains minor CSS inefficiency with gap-x-4 on single-button container.
pcweb/pages/meeting_successfully_booked.py 4/5 Improved UI from markdown to components, made page discoverable. Contains minor CSS inefficiency with gap-x-4 on single-button container.

Sequence Diagram

sequenceDiagram
    participant User
    participant DemoForm as Demo Request Form
    participant ThankYou as /thank-you Page
    participant CalCom as Calendar System
    participant MeetingBooked as /meeting-successfully-booked Page
    participant Home as Home Page (/)

    Note over User,Home: Demo Request Flow
    User->>DemoForm: Submit demo request
    DemoForm->>ThankYou: Redirect to /thank-you
    ThankYou->>User: Display "Check your email" message
    Note over ThankYou: Shows gradient heading<br/>with styled text components
    User->>ThankYou: Click "Home" button
    ThankYou->>Home: rx.redirect("/")

    Note over User,Home: Meeting Booking Flow
    User->>CalCom: Schedule meeting via calendar link
    CalCom->>MeetingBooked: Redirect to /meeting-successfully-booked
    MeetingBooked->>User: Display "Meeting Successfully Booked!" message
    Note over MeetingBooked: Shows gradient heading<br/>with confirmation text
    User->>MeetingBooked: Click "Home" button
    MeetingBooked->>Home: rx.redirect("/")
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Comment on lines +21 to +25
rx.box(
ui.button("Home", variant="primary", size="lg", on_click=rx.redirect("/")),
class_name="flex flex-row items-center gap-x-4 mt-8",
),
class_name="h-[60vh] w-full flex flex-col items-center justify-center p-4",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gap-x-4 class in the wrapper box is unnecessary since there's only one button. The gap-x-4 utility adds horizontal spacing between flex items, but with a single child element, this has no effect.

Consider removing gap-x-4 from the class name, or if you plan to add a second button (like "Installation" as seen in similar pages like /booked and /to-be-booked), then the gap class would be appropriate.

Suggested change
rx.box(
ui.button("Home", variant="primary", size="lg", on_click=rx.redirect("/")),
class_name="flex flex-row items-center gap-x-4 mt-8",
),
class_name="h-[60vh] w-full flex flex-col items-center justify-center p-4",
class_name="flex flex-row items-center mt-8",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/check_your_email_demo.py
Line: 21:25

Comment:
The `gap-x-4` class in the wrapper box is unnecessary since there's only one button. The `gap-x-4` utility adds horizontal spacing between flex items, but with a single child element, this has no effect.

Consider removing `gap-x-4` from the class name, or if you plan to add a second button (like "Installation" as seen in similar pages like `/booked` and `/to-be-booked`), then the gap class would be appropriate.

```suggestion
            class_name="flex flex-row items-center mt-8",
```

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

Comment on lines +21 to +25
rx.box(
ui.button("Home", variant="primary", size="lg", on_click=rx.redirect("/")),
class_name="flex flex-row items-center gap-x-4 mt-8",
),
class_name="h-[60vh] w-full flex flex-col items-center justify-center p-4",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gap-x-4 class in the wrapper box is unnecessary since there's only one button. The gap-x-4 utility adds horizontal spacing between flex items, but with a single child element, this has no effect.

Consider removing gap-x-4 from the class name, or if you plan to add a second button (like "Installation" as seen in similar pages like /booked and /to-be-booked), then the gap class would be appropriate.

Suggested change
rx.box(
ui.button("Home", variant="primary", size="lg", on_click=rx.redirect("/")),
class_name="flex flex-row items-center gap-x-4 mt-8",
),
class_name="h-[60vh] w-full flex flex-col items-center justify-center p-4",
class_name="flex flex-row items-center mt-8",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/meeting_successfully_booked.py
Line: 21:25

Comment:
The `gap-x-4` class in the wrapper box is unnecessary since there's only one button. The `gap-x-4` utility adds horizontal spacing between flex items, but with a single child element, this has no effect.

Consider removing `gap-x-4` from the class name, or if you plan to add a second button (like "Installation" as seen in similar pages like `/booked` and `/to-be-booked`), then the gap class would be appropriate.

```suggestion
            class_name="flex flex-row items-center mt-8",
```

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

@Alek99 Alek99 merged commit cd8fc4a into main Jan 10, 2026
10 checks passed
@Alek99 Alek99 deleted the fix-missing-success-pages branch January 10, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants