Skip to content

move open source templates here#1801

Merged
adhami3310 merged 2 commits intomainfrom
move-open-source-templates-here
Mar 31, 2026
Merged

move open source templates here#1801
adhami3310 merged 2 commits intomainfrom
move-open-source-templates-here

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 31, 2026

Greptile Summary

This PR moves the open-source templates gallery into the docs site by adding a new docs/getting_started/open_source_templates.md page and deleting the now-redundant pcweb/components/icons/lucide/lucide.py component. It also adjusts pyproject.toml to pin reflex and reflex-docgen to a companion feature branch, with uv.lock updated accordingly.

Key changes:

  • New page (open_source_templates.md): Embeds the existing gallery grid and sidebar using the TemplatesState/pagination/sidebar from pcweb/pages/gallery/sidebar.py. The component correctly scopes display to templates/ items via the filtered_templates computed var, even though component_grid iterates all gallery_apps_data entries.
  • Deletion of pcweb/components/icons/lucide/lucide.py: No remaining imports — clean removal.
  • pyproject.toml: Both reflex and reflex-docgen are pinned to the remove-all-pcweb-references-from-the-docs feature branch. This is a P1 concern: if that branch is deleted after its upstream PR merges, the build will break.

Confidence Score: 4/5

Not safe to merge until the pyproject.toml dependency branches are resolved back to main or a stable ref.

The new docs page and deleted file are correct and clean, but the pyproject.toml change pins both reflex and reflex-docgen to a temporary feature branch. Once that branch is deleted post-merge, the repo's dependency resolution will fail, breaking all builds.

pyproject.toml — dependency branch must be resolved to a stable ref before merging.

Important Files Changed

Filename Overview
pyproject.toml Both reflex and reflex-docgen are pinned to a feature branch (remove-all-pcweb-references-from-the-docs) instead of main, which will break the build if that branch is deleted after merging.
docs/getting_started/open_source_templates.md New documentation page that embeds the gallery grid and sidebar from the existing gallery infrastructure; component_grid iterates all gallery_apps_data items but the filtered_templates state var naturally scopes display to templates/-only items.
pcweb/components/icons/lucide/lucide.py File deleted; no remaining imports of this module exist in the codebase — clean removal.
uv.lock Lock file updated to reflect the new reflex branch and an orjson version bump; no structural concerns beyond the upstream branch issue in pyproject.toml.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["open_source_templates.md\n(new docs page)"] --> B["gallery() component"]
    B --> C["sidebar()\nfrom gallery/sidebar.py"]
    B --> D["component_grid()"]
    B --> E["pagination()\nfrom gallery/sidebar.py"]
    D --> F["gallery_apps_data\nfrom gallery/apps.py\n(all templates + reflex_build_templates)"]
    F -->|"rx.cond filter"| G["TemplatesState.filtered_templates\n(templates/ folder only)"]
    G --> H["gallery_app_card\n(rendered cards)"]
    C --> I["TemplatesState\n(query, tags, page)"]
Loading

Comments Outside Diff (1)

  1. pyproject.toml, line 22-23 (link)

    P1 Feature branch pinned in production dependency

    Both reflex and reflex-docgen are pointing to the remove-all-pcweb-references-from-the-docs feature branch rather than main. If this branch is deleted or renamed after its upstream PR is merged, this repo's build will immediately fail because uv/pip can no longer resolve the source URL.

    These should be updated to point to @main (or whichever permanent ref is intended) before this PR lands.

Reviews (1): Last reviewed commit: "set to main" | Re-trigger Greptile

@adhami3310 adhami3310 merged commit b004edb into main Mar 31, 2026
10 checks passed
@adhami3310 adhami3310 deleted the move-open-source-templates-here branch March 31, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants