Add meta tags for docpages - #6464
Merged
Merged
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Greptile SummaryAdds per-document social-preview metadata support and centralizes public URL generation.
Confidence Score: 5/5The pull request appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| packages/reflex-docgen/src/reflex_docgen/markdown/_parser.py | Parses description and image as reserved, typed frontmatter fields without treating them as component previews. |
| packages/reflex-docgen/src/reflex_docgen/markdown/_types.py | Extends FrontMatter with backward-compatible optional description and image fields. |
| packages/reflex-docgen/src/reflex_docgen/markdown/transformer/_markdown.py | Preserves populated description and image fields when serializing frontmatter. |
| docs/app/reflex_docs/pages/docs/init.py | Caches frontmatter parsing and propagates per-page preview images into generated documentation routes. |
| docs/app/reflex_docs/reflex_docs.py | Resolves each route's preview image with a default fallback before constructing page metadata. |
| packages/reflex-site-shared/src/reflex_site_shared/utils/url.py | Centralizes deploy URL and frontend-path composition without retaining the previously reported hostname substring check. |
| docs/app/agent_files/_plugin.py | Reuses the shared URL helper for generated Markdown assets and the documentation home link. |
Reviews (4): Last reviewed commit: "Address review findings: guard frontmatt..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…dates # Conflicts: # docs/app/agent_files/_plugin.py # docs/app/reflex_docs/pages/docs/__init__.py # docs/app/reflex_docs/pages/docs/component.py
FarhanAliRaza
previously approved these changes
May 22, 2026
…dates # Conflicts: # docs/app/reflex_docs/pages/docs/__init__.py # docs/app/reflex_docs/pages/docs/component.py # docs/app/reflex_docs/reflex_docs.py # docs/app/reflex_docs/templates/docpage/docpage.py # packages/reflex-docgen/src/reflex_docgen/markdown/_parser.py # packages/reflex-docgen/src/reflex_docgen/markdown/_types.py # packages/reflex-docgen/src/reflex_docgen/markdown/transformer/_markdown.py # tests/units/docgen/test_markdown.py
The agent_files tests patched get_config only in agent_files._plugin, but public URLs are now built via reflex_site_shared.utils.url.public_url which reads the config through its own import; patch both read sites. Add the towncrier news fragment for reflex-docgen's new frontmatter fields.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 12 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
- _frontmatter_for now tolerates read failures (returning None like docs without frontmatter) so an unreadable file can't abort route registration, and parses only the frontmatter block instead of the full document, keeping the per-doc startup cost minimal. - public_url strips all trailing slashes from deploy_url instead of one. - Regression tests for both.
FarhanAliRaza
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.