fix: make Moment a MemoizationLeaf - #6784
Conversation
Greptile SummaryThis PR fixes a bug where passing a stateful Reflex Var as a child to
Confidence Score: 5/5Safe to merge — single-line inheritance change with strong test coverage and an established codebase precedent in reflex-components-recharts. The change is minimal and targeted: adding MemoizationLeaf to Moment's base classes mirrors an identical pattern already used in recharts. The MRO is correct (NoSSRComponent and MemoizationLeaf both ultimately extend Component, and neither NoSSRComponent nor Component shadows _memoization_mode in a way that would override MemoizationLeaf). Two dedicated regression tests verify both the page-level and memo-body-level behavior. No side effects on other components are possible since the change is scoped to the Moment class alone. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix: make Moment a MemoizationLeaf" | Re-trigger Greptile |
Merging this PR will not alter performance
Comparing Footnotes
|
|
i was trying to figure out why i wasn't seeing this in my apps, and everywhere i was using moment was either in a foreach or explicitly memo'd outer component, both of which would mask the bug. |
No description provided.