AppHarness: support headless mode and driver selection #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using environment variables APP_HARNESS_HEADLESS and APP_HARNESS_DRIVER, support switching out the browser engine used by default in the AppHarness.
Lendemor
approved these changes
Oct 13, 2023
| driver = driver_clz() if driver_clz is not None else webdriver.Chrome() | ||
| want_headless = False | ||
| options = None | ||
| if os.environ.get("APP_HARNESS_HEADLESS"): |
Contributor
There was a problem hiding this comment.
Do we start adding the REFLEX_ prefix now for the env vars, or do we use a different PR to change all of them?
Contributor
There was a problem hiding this comment.
Let's have a separate PR where we do this for all the env vars
| if os.environ.get("APP_HARNESS_HEADLESS"): | ||
| want_headless = True | ||
| if driver_clz is None: | ||
| requested_driver = os.environ.get("APP_HARNESS_DRIVER", "Chrome") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using environment variables
APP_HARNESS_HEADLESSandAPP_HARNESS_DRIVER, support switching out the browser engine used by default in the AppHarness.