Skip to content

Conversation

@martinxu9
Copy link
Contributor

@martinxu9 martinxu9 commented Oct 25, 2023

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

  • Fix a bug that does not print the list of enabled regions in reflex deployments regions command.
  • Fetch enabled regions when user deploys interactively. In this case, there is a prepare_deploy call to the hosting server. If we have a list of enabled regions, we check user input against it.
  • Example of it running: image
  • Change the prompt for deployment name to
Choose a name for your deployed app (quiz-lime-moon):
  • Add a prompt to let user confirm if they have all deps in requirements.txt if only reflex is found in there: image

@martinxu9 martinxu9 requested a review from picklelo October 25, 2023 18:04
@martinxu9 martinxu9 requested a review from Alek99 October 25, 2023 22:05

if enabled_regions is None or region_input in enabled_regions:
break
else:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: don't need the else case since the if case breaks

@picklelo picklelo merged commit fe01f0c into main Oct 26, 2023
@picklelo picklelo deleted the martinxu9/region-check-upfront branch November 1, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants