Use singleton app provider to speed up compiles#2172
Merged
Conversation
masenf
reviewed
Nov 15, 2023
Collaborator
masenf
left a comment
masenf
left a comment
There was a problem hiding this comment.
Is this actually a noticeable difference??
picklelo
force-pushed
the
nikhil/provider
branch
from
64bef03 to
cbd4dd2
Compare
Contributor
Author
|
The provider added around 1-2 seconds to the compile time so it made a difference. With the changes so far I've brought it down to 4s now. |
picklelo
force-pushed
the
nikhil/provider
branch
from
abcf857 to
f1a4c11
Compare
masenf
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were creating the AppProvider for every component - this change creates a singleton for the Chakra provider to speed up build times.