Skip to content

Pass export function with more args to hosting CLI#2254

Merged
picklelo merged 9 commits intomainfrom
martinxu9/export-more-args
Dec 5, 2023
Merged

Pass export function with more args to hosting CLI#2254
picklelo merged 9 commits intomainfrom
martinxu9/export-more-args

Conversation

@martinxu9
Copy link
Copy Markdown
Contributor

@martinxu9 martinxu9 commented Dec 4, 2023

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

  • For decoupling the backend/frontend deployment, the CLI core logic needs the control of backend/frontend only export. Pass those are args to let hosting CLI decide what to do.
  • Bump the minimum required version of CLI to 0.1.1 (TODO: before merging)
    Tests:
  • Pin a published pre-release version of hosting CLI to test deployment (DO NOT MERGE)

@martinxu9 martinxu9 requested a review from picklelo December 4, 2023 17:21
@martinxu9 martinxu9 changed the title Pass export function with more args to hosting CLI Pass export function with more args to hosting CLI [DO NOT MERGE] Dec 4, 2023
@martinxu9 martinxu9 requested a review from Alek99 December 4, 2023 23:29
Comment thread pyproject.toml Outdated
packaging = "^23.1"
pipdeptree = "^2.13.0"
reflex-hosting-cli = ">=0.1.0"
reflex-hosting-cli = "==0.1.1a2"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will publish the CLI pypi and change this to >=0.1.1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is done now.

@martinxu9 martinxu9 changed the title Pass export function with more args to hosting CLI [DO NOT MERGE] Pass export function with more args to hosting CLI Dec 4, 2023
@martinxu9
Copy link
Copy Markdown
Contributor Author

@Alek99 now this PR is ready

@martinxu9
Copy link
Copy Markdown
Contributor Author

martinxu9 commented Dec 4, 2023

@Alek99 now this PR is ready

@Alek99 sorry it's not, messed up something, fixed now

@picklelo picklelo merged commit 0fff63a into main Dec 5, 2023
@martinxu9 martinxu9 deleted the martinxu9/export-more-args branch December 5, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants