Warning if newer reflex/reflex-hosting-cli available #2271
Merged
Conversation
added 2 commits
December 6, 2023 17:49
Member
Author
|
Old screen shot looks like 'Warning: Your version (0.3.4) of reflex is out of date. Upgrade to 0.3.6 with 'pip install reflex --upgrade'' |
Alek99
changed the title
Alek99
changed the title
picklelo
reviewed
Dec 7, 2023
martinxu9
reviewed
Dec 7, 2023
| data = response.json() | ||
|
|
||
| latest_version = data["info"]["version"] | ||
| current_version = version.parse(constants.Reflex.VERSION) |
Contributor
There was a problem hiding this comment.
does this mean we're always checking against the reflex version?
Member
Author
|
Ended up not needed to subprocess the check is basically instant and starting a thread didn't seem to produce a noticeable difference |
martinxu9
approved these changes
Dec 9, 2023
| f"Your version ({current_version}) of {package_name} is out of date. Upgrade to {latest_version} with 'pip install {package_name} --upgrade'" | ||
| ) | ||
| except Exception: | ||
| pass |
Contributor
There was a problem hiding this comment.
nit: there's a contextlib.suppress if the intent here is we do not care about any exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check_latest_package_version when given a package this checks if there is a newer python package and throws a warning to upgrades. Used in run and init to check for reflex and reflex-hosting-cli in deploy