[REF-1464] Handle requirements.txt encoding#2284
Conversation
| packaging = "^23.1" | ||
| pipdeptree = "^2.13.0" | ||
| reflex-hosting-cli = ">=0.1.2" | ||
| charset-normalizer = "^3.3.2" |
There was a problem hiding this comment.
just out of curiosity, was chardet considered for this? it's what i've mostly seen used in the past, but i see it hasn't had a release for quite some time.
There was a problem hiding this comment.
Not really, I didn't look into that. I saw some online answers using this, and this seems to be a dependency of some of current packages already.
But I will double check what people say about those two before merging.
There was a problem hiding this comment.
oh nice, charset-normalizer already being in our installed payload makes this an easy decision
There was a problem hiding this comment.
Oh ok. Let's use this package for now. It's in a rather tiny area of our code
|
@masenf thumbs up one more time please |
masenf
left a comment
There was a problem hiding this comment.
sorry, thought this already merged
No worries. I think our branch is set up to dismiss approvals if there's any new changes. I needed to merge upstream |
All Submissions:
Type of change
Please delete options that are not relevant.
New Feature Submission:
Changes To Core Features:
After these steps, you're ready to open a pull request.
requirements.txtin user local environment assumesutf-8the default encoding used in builtin open method. If user has a different encoding, we open and append will cause the file to have inconsistent encoding on different lines and make part of the content unreadable using any given encoding